Commit cabe7c10 authored Oct 24, 2019 by Luo Jiaxing Committed by Martin K. Petersen Oct 24, 2019

scsi: hisi_sas: Delete the debugfs folder of hisi_sas when the probe fails

Although if the debugfs initialization fails, we will delete the debugfs
folder of hisi_sas, but we did not consider the scenario where debugfs was
successfully initialized, but the probe failed for other reasons. We found
out that hisi_sas folder is still remain after the probe failed.

When probe fail, we should delete debugfs folder to avoid the above issue.

Link: https://lore.kernel.org/r/1571926105-74636-18-git-send-email-john.garry@huawei.com

Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 8f643298

drivers/scsi/hisi_sas/hisi_sas_main.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2686,6 +2686,7 @@ int hisi_sas_probe(struct platform_device *pdev,
		err_out_register_ha:
		scsi_remove_host(shost);
		err_out_ha:
		hisi_sas_debugfs_exit(hisi_hba);
		hisi_sas_free(hisi_hba);
		scsi_host_put(shost);
		return rc;

+1 −0

Original line number	Diff line number	Diff line
		@@ -3266,6 +3266,7 @@ hisi_sas_v3_probe(struct pci_dev pdev, const struct pci_device_id id)
		err_out_register_ha:
		scsi_remove_host(shost);
		err_out_ha:
		hisi_sas_debugfs_exit(hisi_hba);
		scsi_host_put(shost);
		err_out_regions:
		pci_release_regions(pdev);