libertas: no need to check return value of debugfs_create functions (caac453a) · Commits · 戴 / test

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Kalle Valo <kvalo@codeaurora.org> Cc: libertas-dev@lists.infradead.org Cc: linux-wireless@vger.kernel.org Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:

Kalle Valo <kvalo@codeaurora.org>

drivers/net/wireless/marvell/libertas/debugfs.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -708,8 +708,6 @@ void lbs_debugfs_init_one(struct lbs_private priv, struct net_device dev)
		goto exit;

		priv->debugfs_dir = debugfs_create_dir(dev->name, lbs_dir);
		if (!priv->debugfs_dir)
		goto exit;

		for (i=0; i<ARRAY_SIZE(debugfs_files); i++) {
		files = &debugfs_files[i];
		@@ -721,8 +719,6 @@ void lbs_debugfs_init_one(struct lbs_private priv, struct net_device dev)
		}

		priv->events_dir = debugfs_create_dir("subscribed_events", priv->debugfs_dir);
		if (!priv->events_dir)
		goto exit;

		for (i=0; i<ARRAY_SIZE(debugfs_events_files); i++) {
		files = &debugfs_events_files[i];
		@@ -734,8 +730,6 @@ void lbs_debugfs_init_one(struct lbs_private priv, struct net_device dev)
		}

		priv->regs_dir = debugfs_create_dir("registers", priv->debugfs_dir);
		if (!priv->regs_dir)
		goto exit;

		for (i=0; i<ARRAY_SIZE(debugfs_regs_files); i++) {
		files = &debugfs_regs_files[i];

Admin message