Commit ca9eb49a authored Feb 08, 2016 by James Hogan Committed by Ralf Baechle May 13, 2016

SIGNAL: Move generic copy_siginfo() to signal.h



The generic copy_siginfo() is currently defined in
asm-generic/siginfo.h, after including uapi/asm-generic/siginfo.h which
defines the generic struct siginfo. However this makes it awkward for an
architecture to use it if it has to define its own struct siginfo (e.g.
MIPS and potentially IA64), since it means that asm-generic/siginfo.h
can only be included after defining the arch-specific siginfo, which may
be problematic if the arch-specific definition needs definitions from
uapi/asm-generic/siginfo.h.

It is possible to work around this by first including
uapi/asm-generic/siginfo.h to get the constants before defining the
arch-specific siginfo, and include asm-generic/siginfo.h after. However
uapi headers can't be included by other uapi headers, so that first
include has to be in an ifdef __kernel__, with the non __kernel__ case
including the non-UAPI header instead.

Instead of that mess, move the generic copy_siginfo() definition into
linux/signal.h, which allows an arch-specific uapi/asm/siginfo.h to
include asm-generic/siginfo.h and define the arch-specific siginfo, and
for the generic copy_siginfo() to see that arch-specific definition.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Petr Malat <oss@malat.biz>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: Christopher Ferris <cferris@google.com>
Cc: linux-arch@vger.kernel.org
Cc: linux-mips@linux-mips.org
Cc: linux-ia64@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: <stable@vger.kernel.org> # 4.0-
Patchwork: https://patchwork.linux-mips.org/patch/12478/


Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

parent 0e8c1a32

include/asm-generic/siginfo.h

+0 −15

Original line number	Diff line number	Diff line
		@@ -17,21 +17,6 @@
		struct siginfo;
		void do_schedule_next_timer(struct siginfo *info);

		#ifndef HAVE_ARCH_COPY_SIGINFO

		#include <linux/string.h>

		static inline void copy_siginfo(struct siginfo to, struct siginfo from)
		{
		if (from->si_code < 0)
		memcpy(to, from, sizeof(*to));
		else
		/* _sigchld is currently the largest know union member */
		memcpy(to, from, __ARCH_SI_PREAMBLE_SIZE + sizeof(from->_sifields._sigchld));
		}

		#endif

		extern int copy_siginfo_to_user(struct siginfo __user to, const struct siginfo from);

		#endif

include/linux/signal.h

+15 −0

Original line number	Diff line number	Diff line
		@@ -28,6 +28,21 @@ struct sigpending {
		sigset_t signal;
		};

		#ifndef HAVE_ARCH_COPY_SIGINFO

		#include <linux/string.h>

		static inline void copy_siginfo(struct siginfo to, struct siginfo from)
		{
		if (from->si_code < 0)
		memcpy(to, from, sizeof(*to));
		else
		/* _sigchld is currently the largest know union member */
		memcpy(to, from, __ARCH_SI_PREAMBLE_SIZE + sizeof(from->_sifields._sigchld));
		}

		#endif

		/*
		* Define some primitives to manipulate sigset_t.
		*/

Admin message