export_report: use warn() to issue WARNING, so they go to stderr (ca995cbf) · Commits · 戴 / test

Also count CONFIG_MODVERSIONS warnings, and print a NOTE at start of SECTION 2 if any were issued. Section 2 will be empty if the build is lacking this CONFIG_ item, and user may have missed the warnings, as they're off screen. Signed-off-by:

Jim Cromie <jim.cromie@gmail.com> Signed-off-by:

Michal Marek <mmarek@suse.cz>

scripts/export_report.pl

+7 −1

Original line number	Diff line number	Diff line
		@@ -102,6 +102,8 @@ close($module_symvers);
		#
		# collect the usage count of each symbol.
		#
		my $modversion_warnings = 0;

		foreach my $thismod (@allcfiles) {
		my $module;

		@@ -132,7 +134,8 @@ foreach my $thismod (@allcfiles) {
		}
		}
		if ($state != 2) {
		print "WARNING:$thismod is not built with CONFIG_MODVERSION enabled\n";
		warn "WARNING:$thismod is not built with CONFIG_MODVERSIONS enabled\n";
		$modversion_warnings++;
		}
		close($module);
		}
		@@ -166,6 +169,9 @@ printf("SECTION 2:\n\tThis section reports export-symbol-usage of in-kernel
		modules. Each module lists the modules, and the symbols from that module that
		it uses. Each listed symbol reports the number of modules using it\n");

		print "\nNOTE: Got $modversion_warnings CONFIG_MODVERSIONS warnings\n\n"
		if $modversion_warnings;

		print "~"x80 , "\n";
		for my $thismod (sort keys %MODULE) {
		my $list = $MODULE{$thismod};

Admin message