Commit ca96b625 authored by Lucas Stach's avatar Lucas Stach Committed by Linus Torvalds
Browse files

mm: alloc_contig_range: allow to specify GFP mask 

Currently alloc_contig_range assumes that the compaction should be done
with the default GFP_KERNEL flags.  This is probably right for all
current uses of this interface, but may change as CMA is used in more
use-cases (including being the default DMA memory allocator on some
platforms).

Change the function prototype, to allow for passing through the GFP mask
set by upper layers.

Also respect global restrictions by applying memalloc_noio_flags to the
passed in flags.

Link: http://lkml.kernel.org/r/20170127172328.18574-1-l.stach@pengutronix.de


Signed-off-by: default avatarLucas Stach <l.stach@pengutronix.de>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Acked-by: default avatarVlastimil Babka <vbabka@suse.cz>
Cc: Radim Krcmar <rkrcmar@redhat.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Chris Zankel <chris@zankel.net>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Alexander Graf <agraf@suse.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 5a02026d

include/linux/gfp.h

+1 −1
Original line number Diff line number Diff line
@@ -541,7 +541,7 @@ static inline bool pm_suspended_storage(void) 
#if (defined(CONFIG_MEMORY_ISOLATION) && defined(CONFIG_COMPACTION)) || defined(CONFIG_CMA)

/* The below functions must be run on a range from a single zone. */

extern int alloc_contig_range(unsigned long start, unsigned long end,

			      unsigned migratetype);

			      unsigned migratetype, gfp_t gfp_mask);

extern void free_contig_range(unsigned long pfn, unsigned nr_pages);

#endif

mm/cma.c

+2 −1
Original line number Diff line number Diff line
@@ -402,7 +402,8 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align) 


		pfn = cma->base_pfn + (bitmap_no << cma->order_per_bit);

		mutex_lock(&cma_mutex);

		ret = alloc_contig_range(pfn, pfn + count, MIGRATE_CMA);

		ret = alloc_contig_range(pfn, pfn + count, MIGRATE_CMA,

					 GFP_KERNEL);

		mutex_unlock(&cma_mutex);

		if (ret == 0) {

			page = pfn_to_page(pfn);

mm/hugetlb.c

+2 −1
Original line number Diff line number Diff line
@@ -1052,7 +1052,8 @@ static int __alloc_gigantic_page(unsigned long start_pfn, 
				unsigned long nr_pages)

{

	unsigned long end_pfn = start_pfn + nr_pages;

	return alloc_contig_range(start_pfn, end_pfn, MIGRATE_MOVABLE);

	return alloc_contig_range(start_pfn, end_pfn, MIGRATE_MOVABLE,

				  GFP_KERNEL);

}



static bool pfn_range_valid_gigantic(struct zone *z,

mm/page_alloc.c

+3 −2
Original line number Diff line number Diff line
@@ -7399,6 +7399,7 @@ static int __alloc_contig_migrate_range(struct compact_control *cc, 
 *			#MIGRATE_MOVABLE or #MIGRATE_CMA).  All pageblocks

 *			in range must have the same migratetype and it must

 *			be either of the two.

 * @gfp_mask:	GFP mask to use during compaction

 *

 * The PFN range does not have to be pageblock or MAX_ORDER_NR_PAGES

 * aligned, however it's the caller's responsibility to guarantee that
@@ -7412,7 +7413,7 @@ static int __alloc_contig_migrate_range(struct compact_control *cc, 
 * need to be freed with free_contig_range().

 */

int alloc_contig_range(unsigned long start, unsigned long end,

		       unsigned migratetype)

		       unsigned migratetype, gfp_t gfp_mask)

{

	unsigned long outer_start, outer_end;

	unsigned int order;
@@ -7424,7 +7425,7 @@ int alloc_contig_range(unsigned long start, unsigned long end, 
		.zone = page_zone(pfn_to_page(start)),

		.mode = MIGRATE_SYNC,

		.ignore_skip_hint = true,

		.gfp_mask = GFP_KERNEL,

		.gfp_mask = memalloc_noio_flags(gfp_mask),

	};

	INIT_LIST_HEAD(&cc.migratepages);

CRA Git | Maintained and supported by SUSTech CRA and CCSE