Commit ca8ff6ac authored May 15, 2015 by Fabio Estevam Committed by Dmitry Torokhov May 15, 2015

Input: wm831x-on - pass the IRQF_ONESHOT flag



Since commit 1c6c6952 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.

So pass the IRQF_ONESHOT flag in this case.

The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 4be01a29

drivers/input/misc/wm831x-on.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -99,7 +99,8 @@ static int wm831x_on_probe(struct platform_device *pdev)
		wm831x_on->dev->dev.parent = &pdev->dev;

		ret = request_threaded_irq(irq, NULL, wm831x_on_irq,
		IRQF_TRIGGER_RISING, "wm831x_on",
		IRQF_TRIGGER_RISING \| IRQF_ONESHOT,
		"wm831x_on",
		wm831x_on);
		if (ret < 0) {
		dev_err(&pdev->dev, "Unable to request IRQ: %d\n", ret);

Admin message