drm/amd/pp: Refine the OD state checking code in smu7 (ca6e0c5b) · Commits · 戴 / test

if vddc restore to default value, driver clear the bit of DPMTABLE_OD_UPDATE_VDDC and need to repopulate sclk and mclk table. 1. Remove variable i checking code. 2. move clear DPMTABLE_OD_UPDATE_VDDC bit to the end of the function to avoid sclk table will not be updated. Reviewed-by:

Alex Deucher <alexander.deucher@amd.com> Signed-off-by:

Rex Zhu <Rex.Zhu@amd.com> Signed-off-by:

Alex Deucher <alexander.deucher@amd.com>

drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c

+2 −6

Original line number	Diff line number	Diff line
		@@ -4683,10 +4683,6 @@ static void smu7_check_dpm_table_updated(struct pp_hwmgr *hwmgr)
		return;
		}
		}
		if (i == dep_table->count && data->need_update_smu7_dpm_table & DPMTABLE_OD_UPDATE_VDDC) {
		data->need_update_smu7_dpm_table &= ~DPMTABLE_OD_UPDATE_VDDC;
		data->need_update_smu7_dpm_table \|= DPMTABLE_OD_UPDATE_MCLK;
		}

		dep_table = table_info->vdd_dep_on_sclk;
		odn_dep_table = (struct phm_ppt_v1_clock_voltage_dependency_table *)&(odn_table->vdd_dependency_on_sclk);
		@@ -4696,9 +4692,9 @@ static void smu7_check_dpm_table_updated(struct pp_hwmgr *hwmgr)
		return;
		}
		}
		if (i == dep_table->count && data->need_update_smu7_dpm_table & DPMTABLE_OD_UPDATE_VDDC) {
		if (data->need_update_smu7_dpm_table & DPMTABLE_OD_UPDATE_VDDC) {
		data->need_update_smu7_dpm_table &= ~DPMTABLE_OD_UPDATE_VDDC;
		data->need_update_smu7_dpm_table \|= DPMTABLE_OD_UPDATE_SCLK;
		data->need_update_smu7_dpm_table \|= DPMTABLE_OD_UPDATE_SCLK \| DPMTABLE_OD_UPDATE_MCLK;
		}
		}

Admin message