Commit ca6827de authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

cpufreq: schedutil: Add util to struct sg_cpu 



Instead of passing util and max between functions while computing the
utilization and capacity, store the former in struct sg_cpu (along
with the latter and bw_dl).

This will allow the current utilization value to be compared with the
one obtained previously (which is requisite for some code changes to
follow this one), but also it causes the code to look slightly more
consistent and cleaner.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent a28b2bfc

kernel/sched/cpufreq_schedutil.c

+20 −22
Original line number Diff line number Diff line
@@ -53,6 +53,7 @@ struct sugov_cpu { 
	unsigned int		iowait_boost;

	u64			last_update;



	unsigned long		util;

	unsigned long		bw_dl;

	unsigned long		max;
@@ -276,16 +277,15 @@ unsigned long schedutil_cpu_util(int cpu, unsigned long util_cfs, 
	return min(max, util);

}



static unsigned long sugov_get_util(struct sugov_cpu *sg_cpu)

static void sugov_get_util(struct sugov_cpu *sg_cpu)

{

	struct rq *rq = cpu_rq(sg_cpu->cpu);

	unsigned long util = cpu_util_cfs(rq);

	unsigned long max = arch_scale_cpu_capacity(sg_cpu->cpu);



	sg_cpu->max = max;

	sg_cpu->bw_dl = cpu_bw_dl(rq);



	return schedutil_cpu_util(sg_cpu->cpu, util, max, FREQUENCY_UTIL, NULL);

	sg_cpu->util = schedutil_cpu_util(sg_cpu->cpu, cpu_util_cfs(rq), max,

					  FREQUENCY_UTIL, NULL);

}



/**
@@ -362,8 +362,6 @@ static void sugov_iowait_boost(struct sugov_cpu *sg_cpu, u64 time, 
 * sugov_iowait_apply() - Apply the IO boost to a CPU.

 * @sg_cpu: the sugov data for the cpu to boost

 * @time: the update time from the caller

 * @util: the utilization to (eventually) boost

 * @max: the maximum value the utilization can be boosted to

 *

 * A CPU running a task which woken up after an IO operation can have its

 * utilization boosted to speed up the completion of those IO operations.
@@ -377,18 +375,17 @@ static void sugov_iowait_boost(struct sugov_cpu *sg_cpu, u64 time, 
 * This mechanism is designed to boost high frequently IO waiting tasks, while

 * being more conservative on tasks which does sporadic IO operations.

 */

static unsigned long sugov_iowait_apply(struct sugov_cpu *sg_cpu, u64 time,

					unsigned long util, unsigned long max)

static void sugov_iowait_apply(struct sugov_cpu *sg_cpu, u64 time)

{

	unsigned long boost;



	/* No boost currently required */

	if (!sg_cpu->iowait_boost)

		return util;

		return;



	/* Reset boost if the CPU appears to have been idle enough */

	if (sugov_iowait_reset(sg_cpu, time, false))

		return util;

		return;



	if (!sg_cpu->iowait_boost_pending) {

		/*
@@ -397,18 +394,19 @@ static unsigned long sugov_iowait_apply(struct sugov_cpu *sg_cpu, u64 time, 
		sg_cpu->iowait_boost >>= 1;

		if (sg_cpu->iowait_boost < IOWAIT_BOOST_MIN) {

			sg_cpu->iowait_boost = 0;

			return util;

			return;

		}

	}



	sg_cpu->iowait_boost_pending = false;



	/*

	 * @util is already in capacity scale; convert iowait_boost

	 * sg_cpu->util is already in capacity scale; convert iowait_boost

	 * into the same scale so we can compare.

	 */

	boost = (sg_cpu->iowait_boost * max) >> SCHED_CAPACITY_SHIFT;

	return max(boost, util);

	boost = (sg_cpu->iowait_boost * sg_cpu->max) >> SCHED_CAPACITY_SHIFT;

	if (sg_cpu->util < boost)

		sg_cpu->util = boost;

}



#ifdef CONFIG_NO_HZ_COMMON
@@ -439,9 +437,8 @@ static void sugov_update_single(struct update_util_data *hook, u64 time, 
{

	struct sugov_cpu *sg_cpu = container_of(hook, struct sugov_cpu, update_util);

	struct sugov_policy *sg_policy = sg_cpu->sg_policy;

	unsigned long util, max;

	unsigned int next_f;

	unsigned int cached_freq = sg_policy->cached_raw_freq;

	unsigned int next_f;



	sugov_iowait_boost(sg_cpu, time, flags);

	sg_cpu->last_update = time;
@@ -451,10 +448,10 @@ static void sugov_update_single(struct update_util_data *hook, u64 time, 
	if (!sugov_should_update_freq(sg_policy, time))

		return;



	util = sugov_get_util(sg_cpu);

	max = sg_cpu->max;

	util = sugov_iowait_apply(sg_cpu, time, util, max);

	next_f = get_next_freq(sg_policy, util, max);

	sugov_get_util(sg_cpu);

	sugov_iowait_apply(sg_cpu, time);



	next_f = get_next_freq(sg_policy, sg_cpu->util, sg_cpu->max);

	/*

	 * Do not reduce the frequency if the CPU has not been idle

	 * recently, as the reduction is likely to be premature then.
@@ -491,9 +488,10 @@ static unsigned int sugov_next_freq_shared(struct sugov_cpu *sg_cpu, u64 time) 
		struct sugov_cpu *j_sg_cpu = &per_cpu(sugov_cpu, j);

		unsigned long j_util, j_max;



		j_util = sugov_get_util(j_sg_cpu);

		sugov_get_util(j_sg_cpu);

		sugov_iowait_apply(j_sg_cpu, time);

		j_util = j_sg_cpu->util;

		j_max = j_sg_cpu->max;

		j_util = sugov_iowait_apply(j_sg_cpu, time, j_util, j_max);



		if (j_util * max > j_max * util) {

			util = j_util;

CRA Git | Maintained and supported by SUSTech CRA and CCSE