Commit ca5e9aba authored by Deepa Dinamani's avatar Deepa Dinamani Committed by David S. Miller
Browse files

time: Add time_types.h 



sys/time.h is the mandated include for many time related
defines. However, linux/time.h overlaps sys/time.h
significantly and this makes including both from userspace
or one from the other impossible.

This also means that userspace can get away with including
sys/time.h whenever it needs linux/time.h and this is what's
been happening in the user world usually.

But, we have new data types that we plan to use in the uapi time
interfaces also defined in the linux/time.h. But, we are unable
to use these types when sys/time.h is included.

Hence, move the new types to a new header, time_types.h.
We intend to eventually have all the uapi defines that the kernel
uses defined in this header.
Note that the plan is to replace uapi interfaces with timeval to
use __kernel_old_timeval, timespec to use __kernel_old_timespec etc.

Reported-by: default avatarRan Rozenstein <ranro@mellanox.com>
Fixes: 9718475e ("socket: Add SO_TIMESTAMPING_NEW")
Signed-off-by: default avatarDeepa Dinamani <deepa.kernel@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a08ef41f

include/uapi/linux/time.h

+1 −35
Original line number Diff line number Diff line
@@ -3,7 +3,7 @@ 
#define _UAPI_LINUX_TIME_H



#include <linux/types.h>



#include <linux/time_types.h>



#ifndef _STRUCT_TIMESPEC

#define _STRUCT_TIMESPEC
@@ -23,7 +23,6 @@ struct timezone { 
	int	tz_dsttime;	/* type of dst correction */

};





/*

 * Names of the interval timers, and structure

 * defining a timer setting:
@@ -42,39 +41,6 @@ struct itimerval { 
	struct timeval it_value;	/* current value */

};



#ifndef __kernel_timespec

struct __kernel_timespec {

	__kernel_time64_t       tv_sec;                 /* seconds */

	long long               tv_nsec;                /* nanoseconds */

};

#endif



#ifndef __kernel_itimerspec

struct __kernel_itimerspec {

	struct __kernel_timespec it_interval;    /* timer period */

	struct __kernel_timespec it_value;       /* timer expiration */

};

#endif



/*

 * legacy timeval structure, only embedded in structures that

 * traditionally used 'timeval' to pass time intervals (not absolute

 * times). Do not add new users. If user space fails to compile

 * here, this is probably because it is not y2038 safe and needs to

 * be changed to use another interface.

 */

#ifndef __kernel_old_timeval

struct __kernel_old_timeval {

	__kernel_long_t tv_sec;

	__kernel_long_t tv_usec;

};

#endif



struct __kernel_sock_timeval {

	__s64 tv_sec;

	__s64 tv_usec;

};



/*

 * The IDs of the various system clocks (for POSIX.1b interval timers):

 */

include/uapi/linux/time_types.h

0 → 100644
+40 −0
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */

#ifndef _UAPI_LINUX_TIME_TYPES_H

#define _UAPI_LINUX_TIME_TYPES_H



#include <linux/types.h>



#ifndef __kernel_timespec

struct __kernel_timespec {

	__kernel_time64_t       tv_sec;                 /* seconds */

	long long               tv_nsec;                /* nanoseconds */

};

#endif



#ifndef __kernel_itimerspec

struct __kernel_itimerspec {

	struct __kernel_timespec it_interval;    /* timer period */

	struct __kernel_timespec it_value;       /* timer expiration */

};

#endif



/*

 * legacy timeval structure, only embedded in structures that

 * traditionally used 'timeval' to pass time intervals (not absolute

 * times). Do not add new users. If user space fails to compile

 * here, this is probably because it is not y2038 safe and needs to

 * be changed to use another interface.

 */

#ifndef __kernel_old_timeval

struct __kernel_old_timeval {

	__kernel_long_t tv_sec;

	__kernel_long_t tv_usec;

};

#endif



struct __kernel_sock_timeval {

	__s64 tv_sec;

	__s64 tv_usec;

};



#endif /* _UAPI_LINUX_TIME_TYPES_H */

CRA Git | Maintained and supported by SUSTech CRA and CCSE