Commit ca3671a8 authored Dec 05, 2011 by Andreas Herrmann Committed by Jesse Barnes Jan 06, 2012

x86/PCI: amd: Kill misleading message about enablement of IO access to PCI ECS]



Commit 24d9b70b (x86: Use PCI method
for enabling AMD extended config space before MSR method) added a
message when IO access to PCI ECS was enabled via access to the NB_CFG
PCI register.  This can lead to a bogus message like

[    0.365177] Extended Config Space enabled on 0 nodes

which is misleading because IO ECS access is subsequently enabled for
AMD CPUs (that support this) by modifying the corresponding NB_CFG
MSR.

Furthermore it's not "Extended Config Space" that is enabled by this
register setting. It's the IO access that is enabled for extended
configruation space.

IMHO the ambiguous message needs to be cancelled.

Cc: Jan Beulich <jbeulich@novell.com>
Cc: Robert Richter <robert.richter@amd.com>
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

parent f676678f

arch/x86/pci/amd_bus.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -403,7 +403,6 @@ static void __init pci_enable_pci_io_ecs(void)
		++n;
		}
		}
		pr_info("Extended Config Space enabled on %u nodes\n", n);
		#endif
		}

Admin message