Commit ca18d51d authored by Paulo Zanoni's avatar Paulo Zanoni
Browse files

drm/i915/fbc: wait for a vblank instead of 50ms when enabling 



Instead of waiting for 50ms, just wait until the next vblank, since
it's the minimum requirement. The whole infrastructure of FBC is based
on vblanks, so waiting for X vblanks instead of X milliseconds sounds
like the correct way to go. Besides, 50ms may be less than a vblank on
super slow modes that may or may not exist.

There are some small improvements in PC state residency (due to the
fact that we're now using 16ms for the common modes instead of 50ms),
but the biggest advantage is still the correctness of being
vblank-based instead of time-based.

v2:
  - Rebase after changing the patch order.
  - Update the commit message.
v3:
  - Fix bogus vblank_get() instead of vblank_count() (Ville).
  - Don't forget to call drm_crtc_vblank_{get,put} (Chris, Ville)
  - Adjust the performance details on the commit message.
v4:
  - Don't grab the FBC mutex just to grab the vblank (Maarten)

Signed-off-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1453406585-10233-1-git-send-email-paulo.r.zanoni@intel.com
parent bbc39699

drivers/gpu/drm/i915/i915_drv.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -921,9 +921,9 @@ struct i915_fbc { 




	struct intel_fbc_work {

	struct intel_fbc_work {

		bool scheduled;

		bool scheduled;

		u32 scheduled_vblank;

		struct work_struct work;

		struct work_struct work;

		struct drm_framebuffer *fb;

		struct drm_framebuffer *fb;

		unsigned long enable_jiffies;

	} work;

	} work;





	const char *no_fbc_reason;

	const char *no_fbc_reason;

drivers/gpu/drm/i915/intel_fbc.c

+29 −10
Original line number Original line Diff line number Diff line
@@ -381,7 +381,17 @@ static void intel_fbc_work_fn(struct work_struct *__work) 
		container_of(__work, struct drm_i915_private, fbc.work.work);

		container_of(__work, struct drm_i915_private, fbc.work.work);

	struct intel_fbc_work *work = &dev_priv->fbc.work;

	struct intel_fbc_work *work = &dev_priv->fbc.work;

	struct intel_crtc *crtc = dev_priv->fbc.crtc;

	struct intel_crtc *crtc = dev_priv->fbc.crtc;

	int delay_ms = 50;

	struct drm_vblank_crtc *vblank = &dev_priv->dev->vblank[crtc->pipe];



	if (drm_crtc_vblank_get(&crtc->base)) {

		DRM_ERROR("vblank not available for FBC on pipe %c\n",

			  pipe_name(crtc->pipe));



		mutex_lock(&dev_priv->fbc.lock);

		work->scheduled = false;

		mutex_unlock(&dev_priv->fbc.lock);

		return;

	}





retry:

retry:

	/* Delay the actual enabling to let pageflipping cease and the

	/* Delay the actual enabling to let pageflipping cease and the
@@ -390,14 +400,16 @@ retry: 
	 * vblank to pass after disabling the FBC before we attempt

	 * vblank to pass after disabling the FBC before we attempt

	 * to modify the control registers.

	 * to modify the control registers.

	 *

	 *

	 * A more complicated solution would involve tracking vblanks

	 * following the termination of the page-flipping sequence

	 * and indeed performing the enable as a co-routine and not

	 * waiting synchronously upon the vblank.

	 *

	 * WaFbcWaitForVBlankBeforeEnable:ilk,snb

	 * WaFbcWaitForVBlankBeforeEnable:ilk,snb

	 *

	 * It is also worth mentioning that since work->scheduled_vblank can be

	 * updated multiple times by the other threads, hitting the timeout is

	 * not an error condition. We'll just end up hitting the "goto retry"

	 * case below.

	 */

	 */

	wait_remaining_ms_from_jiffies(work->enable_jiffies, delay_ms);

	wait_event_timeout(vblank->queue,

		drm_crtc_vblank_count(&crtc->base) != work->scheduled_vblank,

		msecs_to_jiffies(50));





	mutex_lock(&dev_priv->fbc.lock);

	mutex_lock(&dev_priv->fbc.lock);
@@ -406,8 +418,7 @@ retry: 
		goto out;

		goto out;





	/* Were we delayed again while this function was sleeping? */

	/* Were we delayed again while this function was sleeping? */

	if (time_after(work->enable_jiffies + msecs_to_jiffies(delay_ms),

	if (drm_crtc_vblank_count(&crtc->base) == work->scheduled_vblank) {

		       jiffies)) {

		mutex_unlock(&dev_priv->fbc.lock);

		mutex_unlock(&dev_priv->fbc.lock);

		goto retry;

		goto retry;

	}

	}
@@ -419,6 +430,7 @@ retry: 




out:

out:

	mutex_unlock(&dev_priv->fbc.lock);

	mutex_unlock(&dev_priv->fbc.lock);

	drm_crtc_vblank_put(&crtc->base);

}

}





static void intel_fbc_cancel_work(struct drm_i915_private *dev_priv)

static void intel_fbc_cancel_work(struct drm_i915_private *dev_priv)
@@ -434,13 +446,20 @@ static void intel_fbc_schedule_activation(struct intel_crtc *crtc) 




	WARN_ON(!mutex_is_locked(&dev_priv->fbc.lock));

	WARN_ON(!mutex_is_locked(&dev_priv->fbc.lock));





	if (drm_crtc_vblank_get(&crtc->base)) {

		DRM_ERROR("vblank not available for FBC on pipe %c\n",

			  pipe_name(crtc->pipe));

		return;

	}



	/* It is useless to call intel_fbc_cancel_work() in this function since

	/* It is useless to call intel_fbc_cancel_work() in this function since

	 * we're not releasing fbc.lock, so it won't have an opportunity to grab

	 * we're not releasing fbc.lock, so it won't have an opportunity to grab

	 * it to discover that it was cancelled. So we just update the expected

	 * it to discover that it was cancelled. So we just update the expected

	 * jiffy count. */

	 * jiffy count. */

	work->fb = crtc->base.primary->fb;

	work->fb = crtc->base.primary->fb;

	work->scheduled = true;

	work->scheduled = true;

	work->enable_jiffies = jiffies;

	work->scheduled_vblank = drm_crtc_vblank_count(&crtc->base);

	drm_crtc_vblank_put(&crtc->base);





	schedule_work(&work->work);

	schedule_work(&work->work);

}

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE