Commit ca18a852 authored Mar 02, 2020 by Geert Uytterhoeven Committed by Linus Walleij Mar 03, 2020

gpiolib: Fix inverted check in gpiochip_remove()

The optimization to check for requested lines actually optimized for the
uncomon error case, where one of the GPIO lines is still in use.
Hence the error message must be printed when the loop is terminated
early, not when it went through all available GPIO lines.

Fixes: 869233f8 ("gpiolib: Optimize gpiochip_remove() when check for requested line")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20200302082448.11795-1-geert+renesas@glider.be

Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 869233f8

drivers/gpio/gpiolib.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1823,7 +1823,7 @@ void gpiochip_remove(struct gpio_chip *chip)
		}
		spin_unlock_irqrestore(&gpio_lock, flags);

		if (i == gdev->ngpio)
		if (i != gdev->ngpio)
		dev_crit(&gdev->dev,
		"REMOVING GPIOCHIP WITH GPIOS STILL REQUESTED\n");