Commit ca164318 authored May 23, 2013 by Steven Rostedt (Red Hat) Committed by Steven Rostedt May 23, 2013

tracing: Fix crash when ftrace=nop on the kernel command line



If ftrace=<tracer> is on the kernel command line, when that tracer is
registered, it will be initiated by tracing_set_tracer() to execute that
tracer.

The nop tracer is just a stub tracer that is used to have no tracer
enabled. It is assigned at early bootup as it is the default tracer.

But if ftrace=nop is on the kernel command line, the registering of the
nop tracer will call tracing_set_tracer() which will try to execute
the nop tracer. But it expects tr->current_trace to be assigned something
as it usually is assigned to the nop tracer. As it hasn't been assigned
to anything yet, it causes the system to crash.

The simple fix is to move the tr->current_trace = nop before registering
the nop tracer. The functionality is still the same as the nop tracer
doesn't do anything anyway.

Reported-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

parent 6ed01066

kernel/trace/trace.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -6216,10 +6216,15 @@ __init static int tracer_alloc_buffers(void)

		trace_init_cmdlines();

		register_tracer(&nop_trace);

		/*
		* register_tracer() might reference current_trace, so it
		* needs to be set before we register anything. This is
		* just a bootstrap of current_trace anyway.
		*/
		global_trace.current_trace = &nop_trace;

		register_tracer(&nop_trace);

		/* All seems OK, enable tracing */
		tracing_disabled = 0;

Admin message