Commit c9fbd71f authored by Debabrata Banerjee's avatar Debabrata Banerjee Committed by David S. Miller
Browse files

netpoll: allow cleanup to be synchronous 



This fixes a problem introduced by:
commit 2cde6acd ("netpoll: Fix __netpoll_rcu_free so that it can hold the rtnl lock")

When using netconsole on a bond, __netpoll_cleanup can asynchronously
recurse multiple times, each __netpoll_free_async call can result in
more __netpoll_free_async's. This means there is now a race between
cleanup_work queues on multiple netpoll_info's on multiple devices and
the configuration of a new netpoll. For example if a netconsole is set
to enable 0, reconfigured, and enable 1 immediately, this netconsole
will likely not work.

Given the reason for __netpoll_free_async is it can be called when rtnl
is not locked, if it is locked, we should be able to execute
synchronously. It appears to be locked everywhere it's called from.

Generalize the design pattern from the teaming driver for current
callers of __netpoll_free_async.

CC: Neil Horman <nhorman@tuxdriver.com>
CC: "David S. Miller" <davem@davemloft.net>
Signed-off-by: default avatarDebabrata Banerjee <dbanerje@akamai.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2e2d6f03

drivers/net/bonding/bond_main.c

+2 −1
Original line number Diff line number Diff line
@@ -963,7 +963,8 @@ static inline void slave_disable_netpoll(struct slave *slave) 
		return;



	slave->np = NULL;

	__netpoll_free_async(np);



	__netpoll_free(np);

}



static void bond_poll_controller(struct net_device *bond_dev)

drivers/net/macvlan.c

+1 −1
Original line number Diff line number Diff line
@@ -1077,7 +1077,7 @@ static void macvlan_dev_netpoll_cleanup(struct net_device *dev) 


	vlan->netpoll = NULL;



	__netpoll_free_async(netpoll);

	__netpoll_free(netpoll);

}

#endif	/* CONFIG_NET_POLL_CONTROLLER */

drivers/net/team/team.c

+1 −4
Original line number Diff line number Diff line
@@ -1104,10 +1104,7 @@ static void team_port_disable_netpoll(struct team_port *port) 
		return;

	port->np = NULL;



	/* Wait for transmitting packets to finish before freeing. */

	synchronize_rcu_bh();

	__netpoll_cleanup(np);

	kfree(np);

	__netpoll_free(np);

}

#else

static int team_port_enable_netpoll(struct team_port *port)

include/linux/netpoll.h

+1 −3
Original line number Diff line number Diff line
@@ -31,8 +31,6 @@ struct netpoll { 
	bool ipv6;

	u16 local_port, remote_port;

	u8 remote_mac[ETH_ALEN];



	struct work_struct cleanup_work;

};



struct netpoll_info {
@@ -63,7 +61,7 @@ int netpoll_parse_options(struct netpoll *np, char *opt); 
int __netpoll_setup(struct netpoll *np, struct net_device *ndev);

int netpoll_setup(struct netpoll *np);

void __netpoll_cleanup(struct netpoll *np);

void __netpoll_free_async(struct netpoll *np);

void __netpoll_free(struct netpoll *np);

void netpoll_cleanup(struct netpoll *np);

void netpoll_send_skb_on_dev(struct netpoll *np, struct sk_buff *skb,

			     struct net_device *dev);

net/8021q/vlan_dev.c

+1 −2
Original line number Diff line number Diff line
@@ -756,8 +756,7 @@ static void vlan_dev_netpoll_cleanup(struct net_device *dev) 
		return;



	vlan->netpoll = NULL;



	__netpoll_free_async(netpoll);

	__netpoll_free(netpoll);

}

#endif /* CONFIG_NET_POLL_CONTROLLER */

CRA Git | Maintained and supported by SUSTech CRA and CCSE