Commit c9e90429 authored Nov 14, 2013 by Eric Dumazet Committed by David S. Miller Nov 14, 2013

ipv4: fix possible seqlock deadlock



ip4_datagram_connect() being called from process context,
it should use IP_INC_STATS() instead of IP_INC_STATS_BH()
otherwise we can deadlock on 32bit arches, or get corruptions of
SNMP counters.

Fixes: 584bdf8c ("[IPV4]: Fix "ipOutNoRoutes" counter error for TCP and UDP")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 84a035f6

net/ipv4/datagram.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -57,7 +57,7 @@ int ip4_datagram_connect(struct sock sk, struct sockaddr uaddr, int addr_len)
		if (IS_ERR(rt)) {
		err = PTR_ERR(rt);
		if (err == -ENETUNREACH)
		IP_INC_STATS_BH(sock_net(sk), IPSTATS_MIB_OUTNOROUTES);
		IP_INC_STATS(sock_net(sk), IPSTATS_MIB_OUTNOROUTES);
		goto out;
		}

Admin message