Commit c9e87161 authored Aug 29, 2020 by Dinghao Liu Committed by Theodore Ts'o Oct 18, 2020

ext4: fix error handling code in add_new_gdb



When ext4_journal_get_write_access() fails, we should
terminate the execution flow and release n_group_desc,
iloc.bh, dind and gdb_bh.

Cc: stable@kernel.org
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20200829025403.3139-1-dinghao.liu@zju.edu.cn


Signed-off-by: Theodore Ts'o <tytso@mit.edu>

parent aa2f7792

fs/ext4/resize.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -843,8 +843,10 @@ static int add_new_gdb(handle_t handle, struct inode inode,

		BUFFER_TRACE(dind, "get_write_access");
		err = ext4_journal_get_write_access(handle, dind);
		if (unlikely(err))
		if (unlikely(err)) {
		ext4_std_error(sb, err);
		goto errout;
		}

		/* ext4_reserve_inode_write() gets a reference on the iloc */
		err = ext4_reserve_inode_write(handle, inode, &iloc);

Admin message