Commit c9e71002 authored Feb 28, 2008 by Paul E. McKenney Committed by Ingo Molnar Feb 29, 2008

rcupreempt: remove never-migrates assumption from rcu_process_callbacks()



This patch fixes a potentially invalid access to a per-CPU variable in
rcu_process_callbacks().

This per-CPU access needs to be done in such a way as to guarantee that
the code using it cannot move to some other CPU before all uses of the
value accessed have completed.  Even though this code is currently only
invoked from softirq context, which currrently cannot migrate to some
other CPU, life would be better if this code did not silently make such
an assumption.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent ae778869

kernel/rcupreempt.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -952,9 +952,11 @@ static void rcu_process_callbacks(struct softirq_action *unused)
		{
		unsigned long flags;
		struct rcu_head next, list;
		struct rcu_data *rdp = RCU_DATA_ME();
		struct rcu_data *rdp;

		spin_lock_irqsave(&rdp->lock, flags);
		local_irq_save(flags);
		rdp = RCU_DATA_ME();
		spin_lock(&rdp->lock);
		list = rdp->donelist;
		if (list == NULL) {
		spin_unlock_irqrestore(&rdp->lock, flags);

Admin message