Commit c9d7e3da authored May 18, 2020 by Souptick Joarder Committed by Greg Kroah-Hartman May 19, 2020

fpga: dfl: afu: Corrected error handling levels



Corrected error handling goto sequnece. Level put_pages should
be called when pinned pages >= 0 && pinned != npages. Level
free_pages should be called when pinned pages < 0.

Fixes: fa8dda1e ("fpga: dfl: afu: add DFL_FPGA_PORT_DMA_MAP/UNMAP ioctls support")
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Acked-by: Wu Hao <hao.wu@intel.com>
Reviewed-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/1589825991-3545-1-git-send-email-jrdr.linux@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b03025c5

drivers/fpga/dfl-afu-dma-region.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -61,10 +61,10 @@ static int afu_dma_pin_pages(struct dfl_feature_platform_data *pdata,
		region->pages);
		if (pinned < 0) {
		ret = pinned;
		goto put_pages;
		goto free_pages;
		} else if (pinned != npages) {
		ret = -EFAULT;
		goto free_pages;
		goto put_pages;
		}

		dev_dbg(dev, "%d pages pinned\n", pinned);

Admin message