Commit c9cb9e38 authored May 05, 2020 by Bob Peterson Committed by Andreas Gruenbacher May 08, 2020

gfs2: don't call quota_unhold if quotas are not locked



Before this patch, function gfs2_quota_unlock checked if quotas are
turned off, and if so, it branched to label out, which called
gfs2_quota_unhold. With the new system of gfs2_qa_get and put, we
no longer want to call gfs2_quota_unhold or we won't balance our
gets and puts.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>

parent 4ed0c308

fs/gfs2/quota.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1124,7 +1124,7 @@ void gfs2_quota_unlock(struct gfs2_inode *ip)
		int found;

		if (!test_and_clear_bit(GIF_QD_LOCKED, &ip->i_flags))
		goto out;
		return;

		for (x = 0; x < ip->i_qadata->qa_qd_num; x++) {
		struct gfs2_quota_data *qd;
		@@ -1161,7 +1161,6 @@ void gfs2_quota_unlock(struct gfs2_inode *ip)
		qd_unlock(qda[x]);
		}

		out:
		gfs2_quota_unhold(ip);
		}

Admin message