Commit c9b09a92 authored Jul 30, 2020 by Masahiro Yamada

kconfig: qconf: use delete[] instead of delete to free array



cppcheck reports "Mismatching allocation and deallocation".

$ cppcheck scripts/kconfig/qconf.cc
Checking scripts/kconfig/qconf.cc ...
scripts/kconfig/qconf.cc:1242:10: error: Mismatching allocation and deallocation: data [mismatchAllocDealloc]
  delete data;
         ^
scripts/kconfig/qconf.cc:1236:15: note: Mismatching allocation and deallocation: data
 char *data = new char[count + 1];
              ^
scripts/kconfig/qconf.cc:1242:10: note: Mismatching allocation and deallocation: data
  delete data;
         ^
scripts/kconfig/qconf.cc:1255:10: error: Mismatching allocation and deallocation: data [mismatchAllocDealloc]
  delete data;
         ^
scripts/kconfig/qconf.cc:1236:15: note: Mismatching allocation and deallocation: data
 char *data = new char[count + 1];
              ^
scripts/kconfig/qconf.cc:1255:10: note: Mismatching allocation and deallocation: data
  delete data;
         ^

Fixes: c4f7398b ("kconfig: qconf: make debug links work again")
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

parent 0e912c03

scripts/kconfig/qconf.cc

+2 −2

Original line number	Diff line number	Diff line
		@@ -1238,7 +1238,7 @@ void ConfigInfoView::clicked(const QUrl &url)

		if (count < 1) {
		qInfo() << "Clicked link is empty";
		delete data;
		delete[] data;
		return;
		}

		@@ -1251,7 +1251,7 @@ void ConfigInfoView::clicked(const QUrl &url)
		result = sym_re_search(data);
		if (!result) {
		qInfo() << "Clicked symbol is invalid:" << data;
		delete data;
		delete[] data;
		return;
		}

Admin message