Commit c993df5a authored Nov 17, 2020 by Jens Axboe

io_uring: don't double complete failed reissue request



Zorro reports that an xfstest test case is failing, and it turns out that
for the reissue path we can potentially issue a double completion on the
request for the failure path. There's an issue around the retry as well,
but for now, at least just make sure that we handle the error path
correctly.

Cc: stable@vger.kernel.org
Fixes: b63534c4 ("io_uring: re-issue block requests that failed because of resources")
Reported-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 0abed7c6

fs/io_uring.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2578,7 +2578,6 @@ static bool io_resubmit_prep(struct io_kiocb *req, int error)
		}
		end_req:
		req_set_fail_links(req);
		io_req_complete(req, ret);
		return false;
		}
		#endif

Admin message