Commit c984c878 authored by Yoichi Yuasa's avatar Yoichi Yuasa Committed by Ralf Baechle
Browse files

[MIPS] time: Use non-interrupt locks in GT641xx clockevent driver 



set_next_event() and set_mode() are always called with interrupt disabled.
irqsave and irqrestore are not necessary for spinlock.
Pointed out by Atsushi Nemoto.

Signed-off-by: default avatarYoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 2c771a4c

arch/mips/kernel/cevt-gt641xx.c

+4 −6
Original line number Diff line number Diff line
@@ -49,10 +49,9 @@ int gt641xx_timer0_state(void) 
static int gt641xx_timer0_set_next_event(unsigned long delta,

					 struct clock_event_device *evt)

{

	unsigned long flags;

	u32 ctrl;



	spin_lock_irqsave(&gt641xx_timer_lock, flags);

	spin_lock(&gt641xx_timer_lock);



	ctrl = GT_READ(GT_TC_CONTROL_OFS);

	ctrl &= ~(GT_TC_CONTROL_ENTC0_MSK | GT_TC_CONTROL_SELTC0_MSK);
@@ -61,7 +60,7 @@ static int gt641xx_timer0_set_next_event(unsigned long delta, 
	GT_WRITE(GT_TC0_OFS, delta);

	GT_WRITE(GT_TC_CONTROL_OFS, ctrl);



	spin_unlock_irqrestore(&gt641xx_timer_lock, flags);

	spin_unlock(&gt641xx_timer_lock);



	return 0;

}
@@ -69,10 +68,9 @@ static int gt641xx_timer0_set_next_event(unsigned long delta, 
static void gt641xx_timer0_set_mode(enum clock_event_mode mode,

				    struct clock_event_device *evt)

{

	unsigned long flags;

	u32 ctrl;



	spin_lock_irqsave(&gt641xx_timer_lock, flags);

	spin_lock(&gt641xx_timer_lock);



	ctrl = GT_READ(GT_TC_CONTROL_OFS);

	ctrl &= ~(GT_TC_CONTROL_ENTC0_MSK | GT_TC_CONTROL_SELTC0_MSK);
@@ -90,7 +88,7 @@ static void gt641xx_timer0_set_mode(enum clock_event_mode mode, 


	GT_WRITE(GT_TC_CONTROL_OFS, ctrl);



	spin_unlock_irqrestore(&gt641xx_timer_lock, flags);

	spin_unlock(&gt641xx_timer_lock);

}



static void gt641xx_timer0_event_handler(struct clock_event_device *dev)

CRA Git | Maintained and supported by SUSTech CRA and CCSE