Commit c97119b6 authored by Max Gurtovoy's avatar Max Gurtovoy Committed by Jason Gunthorpe
Browse files

IB/isert: remove duplicated error prints 

The isert_post_recv function prints an error in case of failures, so no
need for the callers to add another print.

Link: https://lore.kernel.org/r/20200805121231.166162-2-maxg@mellanox.com


Signed-off-by: default avatarMax Gurtovoy <maxg@mellanox.com>
Acked-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent e6ac9f60

drivers/infiniband/ulp/isert/ib_isert.c

+3 −12
Original line number Diff line number Diff line
@@ -1140,12 +1140,7 @@ isert_handle_iscsi_dataout(struct isert_conn *isert_conn, 
	 * multiple data-outs on the same command can arrive -

	 * so post the buffer before hand

	 */

	rc = isert_post_recv(isert_conn, rx_desc);

	if (rc) {

		isert_err("ib_post_recv failed with %d\n", rc);

		return rc;

	}

	return 0;

	return isert_post_recv(isert_conn, rx_desc);

}



static int
@@ -1722,10 +1717,8 @@ isert_post_response(struct isert_conn *isert_conn, struct isert_cmd *isert_cmd) 
	int ret;



	ret = isert_post_recv(isert_conn, isert_cmd->rx_desc);

	if (ret) {

		isert_err("ib_post_recv failed with %d\n", ret);

	if (ret)

		return ret;

	}



	ret = ib_post_send(isert_conn->qp, &isert_cmd->tx_desc.send_wr, NULL);

	if (ret) {
@@ -2097,10 +2090,8 @@ isert_put_datain(struct iscsi_conn *conn, struct iscsi_cmd *cmd) 
				   &isert_cmd->tx_desc.send_wr);



		rc = isert_post_recv(isert_conn, isert_cmd->rx_desc);

		if (rc) {

			isert_err("ib_post_recv failed with %d\n", rc);

		if (rc)

			return rc;

		}



		chain_wr = &isert_cmd->tx_desc.send_wr;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE