[PATCH] macintosh: don't store i2c_add_driver() return if no further processing done (c9662b4b) · Commits · 戴 / test

therm_pm72.c and windfarm_lm75_sensor.c both store the return from i2c_add_driver() but do no further processing on the result. Simply return what i2c_add_driver() did, instead. Signed-off-by:

Arthur Othieno <a.othieno@bluewin.ch> Acked-by:

Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by:

Andrew Morton <akpm@osdl.org> Signed-off-by:

Linus Torvalds <torvalds@osdl.org>

drivers/macintosh/therm_pm72.c

+1 −6

Original line number	Diff line number	Diff line
		@@ -1988,18 +1988,13 @@ static void fcu_lookup_fans(struct device_node *fcu_node)

		static int fcu_of_probe(struct of_device* dev, const struct of_device_id *match)
		{
		int rc;

		state = state_detached;

		/* Lookup the fans in the device tree */
		fcu_lookup_fans(dev->node);

		/* Add the driver */
		rc = i2c_add_driver(&therm_pm72_driver);
		if (rc < 0)
		return rc;
		return 0;
		return i2c_add_driver(&therm_pm72_driver);
		}

		static int fcu_of_remove(struct of_device* dev)

drivers/macintosh/windfarm_lm75_sensor.c

+1 −6

Original line number	Diff line number	Diff line
		@@ -240,12 +240,7 @@ static int wf_lm75_detach(struct i2c_client *client)

		static int __init wf_lm75_sensor_init(void)
		{
		int rc;

		rc = i2c_add_driver(&wf_lm75_driver);
		if (rc < 0)
		return rc;
		return 0;
		return i2c_add_driver(&wf_lm75_driver);
		}

		static void __exit wf_lm75_sensor_exit(void)

Admin message