ASoC: soc-pcm: remove soc_dpcm_be_digital_mute() (c9645d2a) · Commits · 戴 / test

No one is using soc_dpcm_be_digital_mute(). If it exists only by assumption that "it may be necessary someday", let's remove it now. Otherwise code maintenance will be difficult. We can revive it when we really needed it. Let's remove it, so far. Signed-off-by:

Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Reviewed-by:

Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Reviewed-by:

Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/87blpxbouc.wl-kuninori.morimoto.gx@renesas.com Signed-off-by:

Mark Brown <broonie@kernel.org>

include/sound/soc-dpcm.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -141,7 +141,6 @@ void snd_soc_dpcm_be_set_state(struct snd_soc_pcm_runtime *be, int stream,
		enum snd_soc_dpcm_state state);

		/* internal use only */
		int soc_dpcm_be_digital_mute(struct snd_soc_pcm_runtime *fe, int mute);
		int soc_dpcm_runtime_update(struct snd_soc_card *);

		#ifdef CONFIG_DEBUG_FS

sound/soc/soc-pcm.c

+0 −27

Original line number	Diff line number	Diff line
		@@ -2719,33 +2719,6 @@ out:
		mutex_unlock(&card->mutex);
		return ret;
		}
		int soc_dpcm_be_digital_mute(struct snd_soc_pcm_runtime *fe, int mute)
		{
		struct snd_soc_dpcm *dpcm;
		struct snd_soc_dai *dai;

		for_each_dpcm_be(fe, SNDRV_PCM_STREAM_PLAYBACK, dpcm) {

		struct snd_soc_pcm_runtime *be = dpcm->be;
		int i;

		if (be->dai_link->ignore_suspend)
		continue;

		for_each_rtd_codec_dai(be, i, dai) {
		struct snd_soc_dai_driver *drv = dai->driver;

		dev_dbg(be->dev, "ASoC: BE digital mute %s\n",
		be->dai_link->name);

		if (drv->ops && drv->ops->digital_mute &&
		dai->playback_active)
		drv->ops->digital_mute(dai, mute);
		}
		}

		return 0;
		}

		static int dpcm_fe_dai_open(struct snd_pcm_substream *fe_substream)
		{

Admin message