scsi: lpfc: Fix SLI3 commands being issued on SLI4 devices (c95a3b4b) · Commits · 戴 / test

During debug, it was seen that the driver is issuing commands specific to SLI3 on SLI4 devices. Although the adapter correctly rejected the command, this should not be done. Revise the code to stop sending these commands on a SLI4 adapter. Signed-off-by:

Dick Kennedy <dick.kennedy@broadcom.com> Signed-off-by:

James Smart <jsmart2021@gmail.com> Signed-off-by:

Martin K. Petersen <martin.petersen@oracle.com>

drivers/scsi/lpfc/lpfc_hbadisc.c

+10 −1

Original line number	Diff line number	Diff line
		@@ -932,7 +932,11 @@ lpfc_linkdown(struct lpfc_hba *phba)
		}
		}
		lpfc_destroy_vport_work_array(phba, vports);
		/* Clean up any firmware default rpi's */

		/* Clean up any SLI3 firmware default rpi's */
		if (phba->sli_rev > LPFC_SLI_REV3)
		goto skip_unreg_did;

		mb = mempool_alloc(phba->mbox_mem_pool, GFP_KERNEL);
		if (mb) {
		lpfc_unreg_did(phba, 0xffff, LPFC_UNREG_ALL_DFLT_RPIS, mb);
		@@ -944,6 +948,7 @@ lpfc_linkdown(struct lpfc_hba *phba)
		}
		}

		skip_unreg_did:
		/* Setup myDID for link up if we are in pt2pt mode */
		if (phba->pport->fc_flag & FC_PT2PT) {
		mb = mempool_alloc(phba->mbox_mem_pool, GFP_KERNEL);
		@@ -4983,6 +4988,10 @@ lpfc_unreg_default_rpis(struct lpfc_vport *vport)
		LPFC_MBOXQ_t *mbox;
		int rc;

		/* Unreg DID is an SLI3 operation. */
		if (phba->sli_rev > LPFC_SLI_REV3)
		return;

		mbox = mempool_alloc(phba->mbox_mem_pool, GFP_KERNEL);
		if (mbox) {
		lpfc_unreg_did(phba, vport->vpi, LPFC_UNREG_ALL_DFLT_RPIS,

Admin message