rcu: Make rcu_*_data variables static (c92fb057) · Commits · 戴 / test

rcu_bh_data, rcu_sched_data and rcu_preempt_data are never used outside kernel/rcu/tree.c and thus can be made static. Doing so fixes a section mismatch warning reported by clang when building LLVMLinux with -Wsection, because these variables were declared in .data..percpu and defined in .data..percpu..shared_aligned since commit ("rcu: Use DEFINE_PER_CPU_SHARED_ALIGNED for rcu_data"). Signed-off-by:

Nicolas Iooss <nicolas.iooss_linux@m4x.org> Reviewed-by:

Josh Triplett <josh@joshtriplett.org> Signed-off-by:

Paul E. McKenney <paulmck@linux.vnet.ibm.com>

kernel/rcu/tree.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -91,7 +91,7 @@ static const char *tp_##sname##_varname __used __tracepoint_string = sname##_var

		#define RCU_STATE_INITIALIZER(sname, sabbr, cr) \
		DEFINE_RCU_TPS(sname) \
		DEFINE_PER_CPU_SHARED_ALIGNED(struct rcu_data, sname##_data); \
		static DEFINE_PER_CPU_SHARED_ALIGNED(struct rcu_data, sname##_data); \
		struct rcu_state sname##_state = { \
		.level = { &sname##_state.node[0] }, \
		.rda = &sname##_data, \

kernel/rcu/tree.h

+0 −3

Original line number	Diff line number	Diff line
		@@ -517,14 +517,11 @@ extern struct list_head rcu_struct_flavors;
		* RCU implementation internal declarations:
		*/
		extern struct rcu_state rcu_sched_state;
		DECLARE_PER_CPU(struct rcu_data, rcu_sched_data);

		extern struct rcu_state rcu_bh_state;
		DECLARE_PER_CPU(struct rcu_data, rcu_bh_data);

		#ifdef CONFIG_PREEMPT_RCU
		extern struct rcu_state rcu_preempt_state;
		DECLARE_PER_CPU(struct rcu_data, rcu_preempt_data);
		#endif /* #ifdef CONFIG_PREEMPT_RCU */

		#ifdef CONFIG_RCU_BOOST

Admin message