Commit c92e677b authored Mar 06, 2018 by Quytelda Kahja Committed by Greg Kroah-Hartman Mar 08, 2018

staging: most: Remove unnecessary usage of BUG_ON().



There is no need for the calls to BUG_ON() in this driver, which are
used to check if mbo or mbo->context are NULL; mbo is never NULL, and
if mbo->context is NULL it would have already been dereferenced and
oopsed before reaching the BUG_ON().

Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
Acked-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d956a1a9

drivers/staging/most/core.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -916,7 +916,6 @@ static void arm_mbo(struct mbo *mbo)
		unsigned long flags;
		struct most_channel *c;

		BUG_ON((!mbo) \|\| (!mbo->context));
		c = mbo->context;

		if (c->is_poisoned) {
		@@ -1019,8 +1018,6 @@ static void most_write_completion(struct mbo *mbo)
		{
		struct most_channel *c;

		BUG_ON((!mbo) \|\| (!mbo->context));

		c = mbo->context;
		if (mbo->status == MBO_E_INVAL)
		pr_info("WARN: Tx MBO status: invalid\n");

Admin message