wl18xx: no need to check return value of debugfs_create functions (c922a3a0) · Commits · 戴 / test

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Kalle Valo <kvalo@codeaurora.org> Cc: Tony Lindgren <tony@atomide.com> Cc: linux-wireless@vger.kernel.org Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by:

Tony Lindgren <tony@atomide.com> Signed-off-by:

Kalle Valo <kvalo@codeaurora.org>

drivers/net/wireless/ti/wl18xx/debugfs.c

+1 −19

Original line number	Diff line number	Diff line
		@@ -422,20 +422,10 @@ static const struct file_operations radar_debug_mode_ops = {
		int wl18xx_debugfs_add_files(struct wl1271 *wl,
		struct dentry *rootdir)
		{
		int ret = 0;
		struct dentry entry, stats, *moddir;
		struct dentry stats, moddir;

		moddir = debugfs_create_dir(KBUILD_MODNAME, rootdir);
		if (!moddir \|\| IS_ERR(moddir)) {
		entry = moddir;
		goto err;
		}

		stats = debugfs_create_dir("fw_stats", moddir);
		if (!stats \|\| IS_ERR(stats)) {
		entry = stats;
		goto err;
		}

		DEBUGFS_ADD(clear_fw_stats, stats);

		@@ -590,12 +580,4 @@ int wl18xx_debugfs_add_files(struct wl1271 *wl,
		DEBUGFS_ADD(dynamic_fw_traces, moddir);

		return 0;

		err:
		if (IS_ERR(entry))
		ret = PTR_ERR(entry);
		else
		ret = -ENOMEM;

		return ret;
		}

Admin message