Input: ALPS - fix stuck buttons on some touchpads (c91ed059) · Commits · 戴 / test

Enable button release event redirection to the device that got the button press not only for touchpads with interleaved protocols, but unconditionally for all Alps touchpads. This is required at least for the touchpads in Dell Inspiron 8200 and Latitude d630. Signed-off-by:

Martin Buck <mb-tmp-yvahk-vachg@gromit.dyndns.org> Signed-off-by:

Dmitry Torokhov <dtor@mail.ru>

drivers/input/mouse/alps.c

+17 −30

Original line number	Diff line number	Diff line
		@@ -120,10 +120,6 @@ static void alps_report_buttons(struct psmouse *psmouse,
		struct input_dev dev1, struct input_dev dev2,
		int left, int right, int middle)
		{
		struct alps_data *priv = psmouse->private;
		const struct alps_model_info *model = priv->i;

		if (model->flags & ALPS_PS2_INTERLEAVED) {
		struct input_dev *dev;

		/*
		@@ -145,15 +141,6 @@ static void alps_report_buttons(struct psmouse *psmouse,
		* device later once we report the rest of the events.
		*/
		input_sync(dev2);
		} else {
		/*
		* For devices with non-interleaved packets we know what
		* device buttons belong to so we can simply report them.
		*/
		input_report_key(dev1, BTN_LEFT, left);
		input_report_key(dev1, BTN_RIGHT, right);
		input_report_key(dev1, BTN_MIDDLE, middle);
		}
		}

		static void alps_process_packet(struct psmouse *psmouse)

Admin message