Commit c914570f authored Jan 14, 2015 by Wolfram Sang Committed by Vinod Koul Jan 25, 2015

dmaengine: of: bail out early if "dmas" property is not present



And don't print an error: not configured is not an error.

Reported-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent 640f204b

drivers/dma/of-dma.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -159,6 +159,10 @@ struct dma_chan of_dma_request_slave_channel(struct device_node np,
		return ERR_PTR(-ENODEV);
		}

		/* Silently fail if there is not even the "dmas" property */
		if (!of_find_property(np, "dmas", NULL))
		return ERR_PTR(-ENODEV);

		count = of_property_count_strings(np, "dma-names");
		if (count < 0) {
		pr_err("%s: dma-names property of node '%s' missing or empty\n",

Admin message