Commit c904e32a authored May 13, 2015 by Mark Rutland Committed by Will Deacon May 27, 2015

arm: perf: filter unschedulable events



Different CPU microarchitectures implement different PMU events, and
thus events which can be scheduled on one microarchitecture cannot be
scheduled on another, and vice-versa. Some archicted events behave
differently across microarchitectures, and thus cannot be meaningfully
summed. Due to this, we reject the scheduling of an event on a CPU of a
different microarchitecture to that the event targets.

When the core perf code is scheduling events and encounters an event
which cannot be scheduled, it stops attempting to schedule events. As
the perf core periodically rotates the list of events, for some
proportion of the time events which are unschedulable will block events
which are schedulable, resulting in low utilisation of the hardware
counters.

This patch implements a pmu::filter_match callback such that we can
detect and skip such events while scheduling early, before they can
block the schedulable events. This prevents the low HW counter
utilisation issue.

Acked-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>

parent cc88116d

arch/arm/kernel/perf_event.c

+13 −0

Original line number	Diff line number	Diff line
		@@ -524,6 +524,18 @@ static void armpmu_disable(struct pmu *pmu)
		armpmu->stop(armpmu);
		}

		/*
		* In heterogeneous systems, events are specific to a particular
		* microarchitecture, and aren't suitable for another. Thus, only match CPUs of
		* the same microarchitecture.
		*/
		static int armpmu_filter_match(struct perf_event *event)
		{
		struct arm_pmu *armpmu = to_arm_pmu(event->pmu);
		unsigned int cpu = smp_processor_id();
		return cpumask_test_cpu(cpu, &armpmu->supported_cpus);
		}

		#ifdef CONFIG_PM
		static int armpmu_runtime_resume(struct device *dev)
		{
		@@ -564,6 +576,7 @@ static void armpmu_init(struct arm_pmu *armpmu)
		.start = armpmu_start,
		.stop = armpmu_stop,
		.read = armpmu_read,
		.filter_match = armpmu_filter_match,
		};
		}

Admin message