Commit c8fdd247 authored May 02, 2007 by Andi Kleen Committed by Andi Kleen May 02, 2007

[PATCH] x86: Drop cc-options call for all options supported in gcc 3.2+



The kernel only supports gcc 3.2+ now so it doesn't make sense
anymore to explicitely check for options this compiler version
already has.

This actually fixes a bug. The -mprefered-stack-boundary check
never worked because gcc rightly complains

  CC      arch/i386/kernel/asm-offsets.s
cc1: -mpreferred-stack-boundary=2 is not between 4 and 12

We just never saw the error because of cc-options.
I changed it to 4 to actually work.

Tested by compiling i386 and x86-64 defconfig with gcc 3.2.

Should speed up the build time a tiny bit and improve
stack usage on i386 slightly.

Signed-off-by: Andi Kleen <ak@suse.de>

parent 2a12652c

Makefile

+1 −1

Original line number	Diff line number	Diff line
		@@ -491,7 +491,7 @@ endif
		include $(srctree)/arch/$(ARCH)/Makefile

		ifdef CONFIG_FRAME_POINTER
		CFLAGS += -fno-omit-frame-pointer $(call cc-option,-fno-optimize-sibling-calls,)
		CFLAGS += -fno-omit-frame-pointer -fno-optimize-sibling-calls
		else
		CFLAGS += -fomit-frame-pointer
		endif

arch/i386/Makefile

+1 −1

Original line number	Diff line number	Diff line
		@@ -34,7 +34,7 @@ CHECKFLAGS += -D__i386__
		CFLAGS += -pipe -msoft-float -mregparm=3 -freg-struct-return

		# prevent gcc from keeping the stack 16 byte aligned
		CFLAGS += $(call cc-option,-mpreferred-stack-boundary=2)
		CFLAGS += -mpreferred-stack-boundary=4

		# CPU-specific tuning. Anything which can be shared with UML should go here.
		include $(srctree)/arch/i386/Makefile.cpu

Admin message