Commit c8f3570b authored Dec 08, 2008 by Trent Piepho Committed by Kumar Gala Jan 28, 2009

powerpc/fsl-booke: Allow larger CAM sizes than 256 MB



The code that maps kernel low memory would only use page sizes up to 256
MB.  On E500v2 pages up to 4 GB are supported.

However, a page must be aligned to a multiple of the page's size.  I.e.
256 MB pages must aligned to a 256 MB boundary.  This was enforced by a
requirement that the physical and virtual addresses of the start of lowmem
be aligned to 256 MB.  Clearly requiring 1GB or 4GB alignment to allow
pages of that size isn't acceptable.

To solve this, I simply have adjust_total_lowmem() take alignment into
account when it decides what size pages to use.  Give it PAGE_OFFSET =
0x7000_0000, PHYSICAL_START = 0x3000_0000, and 2GB of RAM, and it will map
pages like this:
PA 0x3000_0000 VA 0x7000_0000 Size 256 MB
PA 0x4000_0000 VA 0x8000_0000 Size 1 GB
PA 0x8000_0000 VA 0xC000_0000 Size 256 MB
PA 0x9000_0000 VA 0xD000_0000 Size 256 MB
PA 0xA000_0000 VA 0xE000_0000 Size 256 MB

Because the lowmem mapping code now takes alignment into account,
PHYSICAL_ALIGN can be lowered from 256 MB to 64 MB.  Even lower might be
possible.  The lowmem code will work down to 4 kB but it's possible some of
the boot code will fail before then.  Poor alignment will force small pages
to be used, which combined with the limited number of TLB1 pages available,
will result in very little memory getting mapped.  So alignments less than
64 MB probably aren't very useful anyway.

Signed-off-by: Trent Piepho <tpiepho@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

parent f88747e7

arch/powerpc/Kconfig

+1 −1

Original line number	Diff line number	Diff line
		@@ -794,7 +794,7 @@ config PHYSICAL_START

		config PHYSICAL_ALIGN
		hex
		default "0x10000000" if FSL_BOOKE
		default "0x04000000" if FSL_BOOKE
		help
		This value puts the alignment restrictions on physical address
		where kernel is loaded and run from. Kernel is compiled for an

arch/powerpc/mm/fsl_booke_mmu.c

+13 −1

Original line number	Diff line number	Diff line
		@@ -179,9 +179,14 @@ void __init
		adjust_total_lowmem(void)
		{
		phys_addr_t ram;
		unsigned int max_cam = 28; /* 2^28 = 256 Mb */
		unsigned int max_cam = (mfspr(SPRN_TLB1CFG) >> 16) & 0xff;
		char buf[ARRAY_SIZE(cam) * 5 + 1], *p = buf;
		int i;
		unsigned long virt = PAGE_OFFSET & 0xffffffffUL;
		unsigned long phys = memstart_addr & 0xffffffffUL;

		/* Convert (4^max) kB to (2^max) bytes */
		max_cam = max_cam * 2 + 10;

		/* adjust lowmem size to __max_low_memory */
		ram = min((phys_addr_t)__max_low_memory, (phys_addr_t)total_lowmem);
		@@ -190,11 +195,18 @@ adjust_total_lowmem(void)
		__max_low_memory = 0;
		for (i = 0; ram && i < ARRAY_SIZE(cam); i++) {
		unsigned int camsize = __ilog2(ram) & ~1U;
		unsigned int align = __ffs(virt \| phys) & ~1U;

		if (camsize > align)
		camsize = align;
		if (camsize > max_cam)
		camsize = max_cam;

		cam[i] = 1UL << camsize;
		ram -= cam[i];
		__max_low_memory += cam[i];
		virt += cam[i];
		phys += cam[i];

		p += sprintf(p, "%lu/", cam[i] >> 20);
		}

Admin message