Commit c8f2efc8 authored by Xenia Ragiadakou's avatar Xenia Ragiadakou Committed by Greg Kroah-Hartman
Browse files

usbcore: fix read of usbdevfs_ctrltransfer fields in proc_control() 



Urb fields are stored in struct usbdevfs_ctrltransfer in CPU byteorder
and not in little endian, so there is no need to be converted.
This bug was reported by sparse.

Signed-off-by: default avatarXenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4d967995

drivers/usb/core/devio.c

+2 −4
Original line number Diff line number Diff line
@@ -898,10 +898,8 @@ static int proc_control(struct dev_state *ps, void __user *arg) 
	snoop(&dev->dev, "control urb: bRequestType=%02x "

		"bRequest=%02x wValue=%04x "

		"wIndex=%04x wLength=%04x\n",

		ctrl.bRequestType, ctrl.bRequest,

		__le16_to_cpup(&ctrl.wValue),

		__le16_to_cpup(&ctrl.wIndex),

		__le16_to_cpup(&ctrl.wLength));

		ctrl.bRequestType, ctrl.bRequest, ctrl.wValue,

		ctrl.wIndex, ctrl.wLength);

	if (ctrl.bRequestType & 0x80) {

		if (ctrl.wLength && !access_ok(VERIFY_WRITE, ctrl.data,

					       ctrl.wLength)) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE