Commit c8de6dbb authored Apr 25, 2014 by Takashi Sakamoto Committed by Takashi Iwai May 26, 2014

ALSA: firewire-lib: Restrict calling flush_context_completion() when context exists

Currently, drivers can bring XRUN state for PCM substreams when error to
queue packets or detecting discontinuity of packet. The application may try to
recover this state by calling snd_pcm_prepare().

Depending on each driver, .prepare() includes restart streaming. Then there
is a state that PCM substreams are running but isochronous contexts are
stopped. In this case, when .pointer() is called, it refers to error pointer.

This commit is for a prevention of this bug.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 7b2d99fa

sound/firewire/amdtp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -898,7 +898,7 @@ EXPORT_SYMBOL(amdtp_stream_start);
		unsigned long amdtp_stream_pcm_pointer(struct amdtp_stream *s)
		{
		/* this optimization is allowed to be racy */
		if (s->pointer_flush)
		if (s->pointer_flush && amdtp_stream_running(s))
		fw_iso_context_flush_completions(s->context);
		else
		s->pointer_flush = true;

Admin message