Commit c8c8218e authored by Cong Wang's avatar Cong Wang Committed by David S. Miller
Browse files

netrom: fix a memory leak in nr_rx_frame() 



When the skb is associated with a new sock, just assigning
it to skb->sk is not sufficient, we have to set its destructor
to free the sock properly too.

Reported-by: default avatar <syzbot+d6636a36d3c34bd88938@syzkaller.appspotmail.com>
Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2e605463

net/netrom/af_netrom.c

+2 −1
Original line number Diff line number Diff line
@@ -869,7 +869,7 @@ int nr_rx_frame(struct sk_buff *skb, struct net_device *dev) 
	unsigned short frametype, flags, window, timeout;

	int ret;



	skb->sk = NULL;		/* Initially we don't know who it's for */

	skb_orphan(skb);



	/*

	 *	skb->data points to the netrom frame start
@@ -968,6 +968,7 @@ int nr_rx_frame(struct sk_buff *skb, struct net_device *dev) 
	window = skb->data[20];



	skb->sk             = make;

	skb->destructor     = sock_efree;

	make->sk_state	    = TCP_ESTABLISHED;



	/* Fill in his circuit details */

CRA Git | Maintained and supported by SUSTech CRA and CCSE