Commit c89e8016 authored May 26, 2009 by Christian Borntraeger Committed by Rusty Russell Jun 12, 2009

virtio: fix id_matching for virtio drivers



This bug never appeared, since all current virtio drivers use
VIRTIO_DEV_ANY_ID for the vendor field. If a real vendor would be used,
the check in virtio_id_match is wrong - it returns 0 if
id->vendor == dev->id.vendor.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

parent 594de1dd

drivers/virtio/virtio.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -61,7 +61,7 @@ static inline int virtio_id_match(const struct virtio_device *dev,
		if (id->device != dev->id.device)
		return 0;

		return id->vendor == VIRTIO_DEV_ANY_ID \|\| id->vendor != dev->id.vendor;
		return id->vendor == VIRTIO_DEV_ANY_ID \|\| id->vendor == dev->id.vendor;
		}

		/* This looks through all the IDs a driver claims to support. If any of them

Admin message