slimbus: make functions slim_ack_txn and slim_alloc_txbuf static (c88c8d7a) · Commits · 戴 / test

The functions slim_ack_txn and slim_alloc_txbuf are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: symbol 'slim_ack_txn' was not declared. Should it be static? symbol 'slim_alloc_txbuf' was not declared. Should it be static? Signed-off-by:

Colin Ian King <colin.king@canonical.com> Signed-off-by:

Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/slimbus/qcom-ctrl.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -146,7 +146,7 @@ static void slim_alloc_rxbuf(struct qcom_slim_ctrl ctrl)
		return ctrl->rx.base + (idx * ctrl->rx.sl_sz);
		}

		void slim_ack_txn(struct qcom_slim_ctrl *ctrl, int err)
		static void slim_ack_txn(struct qcom_slim_ctrl *ctrl, int err)
		{
		struct completion *comp;
		unsigned long flags;
		@@ -299,7 +299,8 @@ static int qcom_clk_pause_wakeup(struct slim_controller *sctrl)
		return 0;
		}

		void slim_alloc_txbuf(struct qcom_slim_ctrl ctrl, struct slim_msg_txn *txn,
		static void slim_alloc_txbuf(struct qcom_slim_ctrl ctrl,
		struct slim_msg_txn *txn,
		struct completion *done)
		{
		unsigned long flags;

Admin message