scsi: lpfc: Fix build error (c88725dd) · Commits · 戴 / test

You can't declare a function inline in a header if it doesn't have a body available to the compiler. So realistically you either don't declare it inline or you make it a static inline in the header. I think the latter applies in this case, so this should be the fix Signed-off-by:

James Bottomley <James.Bottomley@HansenPartnership.com> Acked-by:

James Smart <james.smart@broadcom.com> Signed-off-by:

Martin K. Petersen <martin.petersen@oracle.com>

drivers/scsi/lpfc/lpfc_sli.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -14574,12 +14574,6 @@ out_fail:
		return NULL;
		}

		inline void lpfc_sli4_qe(struct lpfc_queue q, uint16_t idx)
		{
		return q->q_pgs[idx / q->entry_cnt_per_pg] +
		(q->entry_size * (idx % q->entry_cnt_per_pg));
		}

		/**
		* lpfc_dual_chute_pci_bar_map - Map pci base address register to host memory
		* @phba: HBA structure that indicates port to create a queue on.

drivers/scsi/lpfc/lpfc_sli4.h

+5 −1

Original line number	Diff line number	Diff line
		@@ -1080,4 +1080,8 @@ int lpfc_sli4_post_status_check(struct lpfc_hba *);
		uint8_t lpfc_sli_config_mbox_subsys_get(struct lpfc_hba , LPFC_MBOXQ_t );
		uint8_t lpfc_sli_config_mbox_opcode_get(struct lpfc_hba , LPFC_MBOXQ_t );
		void lpfc_sli4_ras_dma_free(struct lpfc_hba *phba);
		inline void lpfc_sli4_qe(struct lpfc_queue , uint16_t);
		static inline void lpfc_sli4_qe(struct lpfc_queue q, uint16_t idx)
		{
		return q->q_pgs[idx / q->entry_cnt_per_pg] +
		(q->entry_size * (idx % q->entry_cnt_per_pg));
		}

Admin message