Commit c87f08ca authored by Chris Mason's avatar Chris Mason
Browse files

Btrfs: allow balance to explicitly allocate chunks as it relocates 



Btrfs device shrinking and balancing ends up reallocating all the blocks
in order to allow COW to move them to new destinations.  It is somewhat
awkward in terms of ENOSPC because most of the enospc code is built
around the idea that some operation on a reference counted tree triggers
allocations in the non-reference counted trees.

This commit changes the balancing code to deal with enospc by trying to
allocate a new chunk.  If that allocation succeeds, we go ahead and
retry whatever failed due to enospc.

Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
parent 91435650

fs/btrfs/ctree.h

+2 −0
Original line number Diff line number Diff line
@@ -2219,6 +2219,8 @@ int btrfs_error_unpin_extent_range(struct btrfs_root *root, 
				   u64 start, u64 end);

int btrfs_error_discard_extent(struct btrfs_root *root, u64 bytenr,

			       u64 num_bytes);

int btrfs_force_chunk_alloc(struct btrfs_trans_handle *trans,

			    struct btrfs_root *root, u64 type);



/* ctree.c */

int btrfs_bin_search(struct extent_buffer *eb, struct btrfs_key *key,

fs/btrfs/extent-tree.c

+7 −0
Original line number Diff line number Diff line
@@ -8066,6 +8066,13 @@ out: 
	return ret;

}



int btrfs_force_chunk_alloc(struct btrfs_trans_handle *trans,

			    struct btrfs_root *root, u64 type)

{

	u64 alloc_flags = get_alloc_profile(root, type);

	return do_chunk_alloc(trans, root, 2 * 1024 * 1024, alloc_flags, 1);

}



/*

 * helper to account the unused space of all the readonly block group in the

 * list. takes mirrors into account.

fs/btrfs/relocation.c

+12 −1
Original line number Diff line number Diff line
@@ -3654,6 +3654,7 @@ static noinline_for_stack int relocate_block_group(struct reloc_control *rc) 
	u32 item_size;

	int ret;

	int err = 0;

	int progress = 0;



	path = btrfs_alloc_path();

	if (!path)
@@ -3666,9 +3667,10 @@ static noinline_for_stack int relocate_block_group(struct reloc_control *rc) 
	}



	while (1) {

		progress++;

		trans = btrfs_start_transaction(rc->extent_root, 0);

		BUG_ON(IS_ERR(trans));



restart:

		if (update_backref_cache(trans, &rc->backref_cache)) {

			btrfs_end_transaction(trans, rc->extent_root);

			continue;
@@ -3781,6 +3783,15 @@ static noinline_for_stack int relocate_block_group(struct reloc_control *rc) 
			}

		}

	}

	if (trans && progress && err == -ENOSPC) {

		ret = btrfs_force_chunk_alloc(trans, rc->extent_root,

					      rc->block_group->flags);

		if (ret == 0) {

			err = 0;

			progress = 0;

			goto restart;

		}

	}



	btrfs_release_path(rc->extent_root, path);

	clear_extent_bits(&rc->processed_blocks, 0, (u64)-1, EXTENT_DIRTY,

CRA Git | Maintained and supported by SUSTech CRA and CCSE