Commit c86936e6 authored Apr 27, 2020 by Leon Romanovsky Committed by Jason Gunthorpe Apr 28, 2020

RDMA/mlx5: Avoid setting redundant NULL for XRC QPs

There is no need to set NULL in recv_cq and send_cq, they are already
set to NULL by the IB/core logic.

Link: https://lore.kernel.org/r/20200427154636.381474-6-leon@kernel.org


Reviewed-by: Maor Gottlieb <maorg@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 9c2ba4ed

drivers/infiniband/hw/mlx5/qp.c

+1 −7

Original line number	Diff line number	Diff line
		@@ -2771,14 +2771,8 @@ struct ib_qp mlx5_ib_create_qp(struct ib_pd pd,
		}
		}

		if (init_attr->qp_type == IB_QPT_XRC_TGT) {
		init_attr->recv_cq = NULL;
		if (init_attr->qp_type == IB_QPT_XRC_TGT)
		xrcdn = to_mxrcd(init_attr->xrcd)->xrcdn;
		init_attr->send_cq = NULL;
		}

		if (init_attr->qp_type == IB_QPT_XRC_INI)
		init_attr->recv_cq = NULL;

		err = create_qp_common(dev, pd, init_attr, udata, qp);
		if (err) {

Admin message