Commit c868907e authored Dec 03, 2019 by Michael Hernandez Committed by Martin K. Petersen Dec 09, 2019

scsi: qla2xxx: Fix incorrect SFUB length used for Secure Flash Update MB Cmd

SFUB length should be in DWORDs when passed to FW.

Fixes: 3f006ac3 ("scsi: qla2xxx: Secure flash update support for ISP28XX")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20191203223657.22109-4-hmadhani@marvell.com


Signed-off-by: Michael Hernandez <mhernandez@marvell.com>
Signed-off-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent a530bf69

drivers/scsi/qla2xxx/qla_sup.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2897,7 +2897,7 @@ qla28xx_write_flash_data(scsi_qla_host_t vha, uint32_t dwptr, uint32_t faddr,
		"Sending Secure Flash MB Cmd\n");
		rval = qla28xx_secure_flash_update(vha, 0, region.code,
		buf_size_without_sfub, sfub_dma,
		sizeof(struct secure_flash_update_block));
		sizeof(struct secure_flash_update_block) >> 2);
		if (rval != QLA_SUCCESS) {
		ql_log(ql_log_warn, vha, 0xffff,
		"Secure Flash MB Cmd failed %x.", rval);

Admin message