Commit c862626e authored by Keqian Zhu's avatar Keqian Zhu Committed by Marc Zyngier
Browse files

KVM: arm64: Support enabling dirty log gradually in small chunks 



There is already support of enabling dirty log gradually in small chunks
for x86 in commit 3c9bd400 ("KVM: x86: enable dirty log gradually in
small chunks"). This adds support for arm64.

x86 still writes protect all huge pages when DIRTY_LOG_INITIALLY_ALL_SET
is enabled. However, for arm64, both huge pages and normal pages can be
write protected gradually by userspace.

Under the Huawei Kunpeng 920 2.6GHz platform, I did some tests on 128G
Linux VMs with different page size. The memory pressure is 127G in each
case. The time taken of memory_global_dirty_log_start in QEMU is listed
below:

Page Size      Before    After Optimization
  4K            650ms         1.8ms
  2M             4ms          1.8ms
  1G             2ms          1.8ms

Besides the time reduction, the biggest improvement is that we will minimize
the performance side effect (because of dissolving huge pages and marking
memslots dirty) on guest after enabling dirty log.

Signed-off-by: default avatarKeqian Zhu <zhukeqian1@huawei.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20200413122023.52583-1-zhukeqian1@huawei.com
parent 0529c902

Documentation/virt/kvm/api.rst

+1 −1
Original line number Diff line number Diff line
@@ -5777,7 +5777,7 @@ will be initialized to 1 when created. This also improves performance because 
dirty logging can be enabled gradually in small chunks on the first call

to KVM_CLEAR_DIRTY_LOG.  KVM_DIRTY_LOG_INITIALLY_SET depends on

KVM_DIRTY_LOG_MANUAL_PROTECT_ENABLE (it is also only available on

x86 for now).

x86 and arm64 for now).



KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 was previously available under the name

KVM_CAP_MANUAL_DIRTY_LOG_PROTECT, but the implementation had bugs that make

arch/arm64/include/asm/kvm_host.h

+3 −0
Original line number Diff line number Diff line
@@ -46,6 +46,9 @@ 
#define KVM_REQ_RECORD_STEAL	KVM_ARCH_REQ(3)

#define KVM_REQ_RELOAD_GICv4	KVM_ARCH_REQ(4)



#define KVM_DIRTY_LOG_MANUAL_CAPS   (KVM_DIRTY_LOG_MANUAL_PROTECT_ENABLE | \

				     KVM_DIRTY_LOG_INITIALLY_SET)



DECLARE_STATIC_KEY_FALSE(userspace_irqchip_in_use);



extern unsigned int kvm_sve_max_vl;

arch/arm64/kvm/mmu.c

+10 −2
Original line number Diff line number Diff line
@@ -2277,9 +2277,17 @@ void kvm_arch_commit_memory_region(struct kvm *kvm, 
	 * allocated dirty_bitmap[], dirty pages will be tracked while the

	 * memory slot is write protected.

	 */

	if (change != KVM_MR_DELETE && mem->flags & KVM_MEM_LOG_DIRTY_PAGES)

	if (change != KVM_MR_DELETE && mem->flags & KVM_MEM_LOG_DIRTY_PAGES) {

		/*

		 * If we're with initial-all-set, we don't need to write

		 * protect any pages because they're all reported as dirty.

		 * Huge pages and normal pages will be write protect gradually.

		 */

		if (!kvm_dirty_log_manual_protect_and_init_set(kvm)) {

			kvm_mmu_wp_memory_region(kvm, mem->slot);

		}

	}

}



int kvm_arch_prepare_memory_region(struct kvm *kvm,

				   struct kvm_memory_slot *memslot,

CRA Git | Maintained and supported by SUSTech CRA and CCSE