Commit c85e2031 authored Aug 19, 2008 by Geert Uytterhoeven Committed by Dmitry Torokhov Aug 19, 2008

Input: evdev - fix printf() format for sizeof



commit f2afa771 ("Input: paper over a bug in
Synaptics X driver") introduced a compiler warning on 64-bit platforms, as
sizeof() returns a size_t, not an (unsigned) int:

| drivers/input/evdev.c: In function 'handle_eviocgbit':
| drivers/input/evdev.c:684: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'

Use the proper `z' modifier for size_t, and make the printf() formats for the
sizes unsigned while we're at it.

Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

parent 0cc1fe22

drivers/input/evdev.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -677,8 +677,8 @@ static int handle_eviocgbit(struct input_dev *dev, unsigned int cmd, void __user
		len = OLD_KEY_MAX;
		if (printk_timed_ratelimit(&keymax_warn_time, 10 * 1000))
		printk(KERN_WARNING
		"evdev.c(EVIOCGBIT): Suspicious buffer size %d, "
		"limiting output to %d bytes. See "
		"evdev.c(EVIOCGBIT): Suspicious buffer size %u, "
		"limiting output to %zu bytes. See "
		"http://userweb.kernel.org/~dtor/eviocgbit-bug.html\n",
		OLD_KEY_MAX,
		BITS_TO_LONGS(OLD_KEY_MAX) * sizeof(long));

Admin message