Commit c835e191 authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo
Browse files

perf annotate: Add annotation_line__(new|delete) functions 



Changing the way the annotation lines are allocated and adding
annotation_line__(new|delete) functions to deal with this.

Before the allocation schema was as follows:

  -----------------------------------------------------------
  struct disasm_line | struct annotation_line | private space
  -----------------------------------------------------------

Where the private space is used in TUI code to store computed
annotation data for events. The stdio code computes the data
on the fly.

The goal is to compute and store annotation line's data directly
in the struct annotation_line itself, so this patch changes the
line allocation schema as follows:

  ------------------------------------------------------------
  privsize space | struct disasm_line | struct annotation_line
  ------------------------------------------------------------

Moving struct annotation_line to the end, because in following
changes we will move here the non-fixed length event's data.

Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20171011150158.11895-15-jolsa@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 5b12adc8

tools/perf/ui/browsers/annotate.c

+3 −1
Original line number Original line Diff line number Diff line
@@ -76,7 +76,9 @@ struct annotate_browser { 




static inline struct browser_disasm_line *disasm_line__browser(struct disasm_line *dl)

static inline struct browser_disasm_line *disasm_line__browser(struct disasm_line *dl)

{

{

	return (struct browser_disasm_line *)(dl + 1);

	struct annotation_line *al = &dl->al;



	return (void *) al - al->privsize;

}

}





static bool disasm_line__filter(struct ui_browser *browser __maybe_unused,

static bool disasm_line__filter(struct ui_browser *browser __maybe_unused,

tools/perf/util/annotate.c

+56 −7
Original line number Original line Diff line number Diff line
@@ -888,14 +888,64 @@ struct annotate_args { 
	int			 line_nr;

	int			 line_nr;

};

};





static void annotation_line__delete(struct annotation_line *al)

{

	void *ptr = (void *) al - al->privsize;



	zfree(&al->line);

	free(ptr);

}



/*

 * Allocating the annotation line data with following

 * structure:

 *

 *    --------------------------------------

 *    private space | struct annotation_line

 *    --------------------------------------

 *

 * Size of the private space is stored in 'struct annotation_line'.

 *

 */

static struct annotation_line *

annotation_line__new(struct annotate_args *args, size_t privsize)

{

	struct annotation_line *al;

	size_t size = privsize + sizeof(*al);



	al = zalloc(size);

	if (al) {

		al = (void *) al + privsize;

		al->privsize   = privsize;

		al->offset     = args->offset;

		al->line       = strdup(args->line);

		al->line_nr    = args->line_nr;

	}



	return al;

}



/*

 * Allocating the disasm annotation line data with

 * following structure:

 *

 *    ------------------------------------------------------------

 *    privsize space | struct disasm_line | struct annotation_line

 *    ------------------------------------------------------------

 *

 * We have 'struct annotation_line' member as last member

 * of 'struct disasm_line' to have an easy access.

 *

 */

static struct disasm_line *disasm_line__new(struct annotate_args *args)

static struct disasm_line *disasm_line__new(struct annotate_args *args)

{

{

	struct disasm_line *dl = zalloc(sizeof(*dl) + args->privsize);

	struct disasm_line *dl = NULL;

	struct annotation_line *al;

	size_t privsize = args->privsize + offsetof(struct disasm_line, al);





	if (dl != NULL) {

	al = annotation_line__new(args, privsize);

		dl->al.offset  = args->offset;

	if (al != NULL) {

		dl->al.line    = strdup(args->line);

		dl = disasm_line(al);

		dl->al.line_nr = args->line_nr;





		if (dl->al.line == NULL)

		if (dl->al.line == NULL)

			goto out_delete;

			goto out_delete;
@@ -919,14 +969,13 @@ out_delete: 




void disasm_line__free(struct disasm_line *dl)

void disasm_line__free(struct disasm_line *dl)

{

{

	zfree(&dl->al.line);

	if (dl->ins.ops && dl->ins.ops->free)

	if (dl->ins.ops && dl->ins.ops->free)

		dl->ins.ops->free(&dl->ops);

		dl->ins.ops->free(&dl->ops);

	else

	else

		ins__delete(&dl->ops);

		ins__delete(&dl->ops);

	free((void *)dl->ins.name);

	free((void *)dl->ins.name);

	dl->ins.name = NULL;

	dl->ins.name = NULL;

	free(dl);

	annotation_line__delete(&dl->al);

}

}





int disasm_line__scnprintf(struct disasm_line *dl, char *bf, size_t size, bool raw)

int disasm_line__scnprintf(struct disasm_line *dl, char *bf, size_t size, bool raw)

tools/perf/util/annotate.h

+9 −1
Original line number Original line Diff line number Diff line
@@ -67,14 +67,22 @@ struct annotation_line { 
	int			 line_nr;

	int			 line_nr;

	float			 ipc;

	float			 ipc;

	u64			 cycles;

	u64			 cycles;

	size_t			 privsize;

};

};





struct disasm_line {

struct disasm_line {

	struct annotation_line	 al;

	struct ins		 ins;

	struct ins		 ins;

	struct ins_operands	 ops;

	struct ins_operands	 ops;



	/* This needs to be at the end. */

	struct annotation_line	 al;

};

};





static inline struct disasm_line *disasm_line(struct annotation_line *al)

{

	return al ? container_of(al, struct disasm_line, al) : NULL;

}



static inline bool disasm_line__has_offset(const struct disasm_line *dl)

static inline bool disasm_line__has_offset(const struct disasm_line *dl)

{

{

	return dl->ops.target.offset_avail;

	return dl->ops.target.offset_avail;

CRA Git | Maintained and supported by SUSTech CRA and CCSE