Commit c822e059 authored by Lionel Landwerlin's avatar Lionel Landwerlin
Browse files

drm/i915: expose rcs topology through query uAPI 

With the introduction of asymmetric slices in CNL, we cannot rely on
the previous SUBSLICE_MASK getparam to tell userspace what subslices
are available. Here we introduce a more detailed way of querying the
Gen's GPU topology that doesn't aggregate numbers.

This is essential for monitoring parts of the GPU with the OA unit,
because counters need to be normalized to the number of
EUs/subslices/slices. The current aggregated numbers like EU_TOTAL do
not gives us sufficient information.

The Mesa series making use of this API is :

    https://patchwork.freedesktop.org/series/38795/

As a bonus we can draw representations of the GPU :

    https://imgur.com/a/vuqpa



v2: Rename uapi struct s/_mask/_info/ (Tvrtko)
    Report max_slice/subslice/eus_per_subslice rather than strides (Tvrtko)
    Add uapi macros to read data from *_info structs (Tvrtko)

v3: Use !!(v & DRM_I915_BIT()) for uapi macros instead of custom shifts (Tvrtko)

v4: factorize query item writting (Tvrtko)
    tweak uapi struct/define names (Tvrtko)

v5: Replace ALIGN() macro (Chris)

v6: Updated uapi comments (Tvrtko)
    Moved flags != 0 checks into vfuncs (Tvrtko)

v7: Use access_ok() before copying anything, to avoid overflows (Chris)
    Switch BUG_ON() to GEM_WARN_ON() (Tvrtko)

v8: Tweak uapi comments style to match the coding style (Lionel)

v9: Fix error in comment about computation of enabled subslice (Tvrtko)

v10: Fix/update comments in uAPI (Sagar)

v11: Drop drm_i915_query_(slice|subslice|eu)_info in favor of a single
     drm_i915_query_topology_info (Joonas)

v12: Add subslice_stride/eu_stride in drm_i915_query_topology_info (Joonas)

v13: Fix comment in uAPI (Joonas)

Signed-off-by: default avatarLionel Landwerlin <lionel.g.landwerlin@intel.com>
Acked-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: default avatarJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180306122857.27317-7-lionel.g.landwerlin@intel.com
parent a446ae2c

drivers/gpu/drm/i915/i915_query.c

+75 −0
Original line number Diff line number Diff line
@@ -8,8 +8,83 @@ 
#include "i915_query.h"

#include <uapi/drm/i915_drm.h>



static int query_topology_info(struct drm_i915_private *dev_priv,

			       struct drm_i915_query_item *query_item)

{

	const struct sseu_dev_info *sseu = &INTEL_INFO(dev_priv)->sseu;

	struct drm_i915_query_topology_info topo;

	u32 slice_length, subslice_length, eu_length, total_length;



	if (query_item->flags != 0)

		return -EINVAL;



	if (sseu->max_slices == 0)

		return -ENODEV;



	BUILD_BUG_ON(sizeof(u8) != sizeof(sseu->slice_mask));



	slice_length = sizeof(sseu->slice_mask);

	subslice_length = sseu->max_slices *

		DIV_ROUND_UP(sseu->max_subslices,

			     sizeof(sseu->subslice_mask[0]) * BITS_PER_BYTE);

	eu_length = sseu->max_slices * sseu->max_subslices *

		DIV_ROUND_UP(sseu->max_eus_per_subslice, BITS_PER_BYTE);



	total_length = sizeof(topo) + slice_length + subslice_length + eu_length;



	if (query_item->length == 0)

		return total_length;



	if (query_item->length < total_length)

		return -EINVAL;



	if (copy_from_user(&topo, u64_to_user_ptr(query_item->data_ptr),

			   sizeof(topo)))

		return -EFAULT;



	if (topo.flags != 0)

		return -EINVAL;



	if (!access_ok(VERIFY_WRITE, u64_to_user_ptr(query_item->data_ptr),

		       total_length))

		return -EFAULT;



	memset(&topo, 0, sizeof(topo));

	topo.max_slices = sseu->max_slices;

	topo.max_subslices = sseu->max_subslices;

	topo.max_eus_per_subslice = sseu->max_eus_per_subslice;



	topo.subslice_offset = slice_length;

	topo.subslice_stride = DIV_ROUND_UP(sseu->max_subslices, BITS_PER_BYTE);

	topo.eu_offset = slice_length + subslice_length;

	topo.eu_stride =

		DIV_ROUND_UP(sseu->max_eus_per_subslice, BITS_PER_BYTE);



	if (__copy_to_user(u64_to_user_ptr(query_item->data_ptr),

			   &topo, sizeof(topo)))

		return -EFAULT;



	if (__copy_to_user(u64_to_user_ptr(query_item->data_ptr + sizeof(topo)),

			   &sseu->slice_mask, slice_length))

		return -EFAULT;



	if (__copy_to_user(u64_to_user_ptr(query_item->data_ptr +

					   sizeof(topo) + slice_length),

			   sseu->subslice_mask, subslice_length))

		return -EFAULT;



	if (__copy_to_user(u64_to_user_ptr(query_item->data_ptr +

					   sizeof(topo) +

					   slice_length + subslice_length),

			   sseu->eu_mask, eu_length))

		return -EFAULT;



	return total_length;

}



static int (* const i915_query_funcs[])(struct drm_i915_private *dev_priv,

					struct drm_i915_query_item *query_item) = {

	query_topology_info,

};



int i915_query_ioctl(struct drm_device *dev, void *data, struct drm_file *file)

include/uapi/drm/i915_drm.h

+62 −0
Original line number Diff line number Diff line
@@ -1619,6 +1619,7 @@ struct drm_i915_perf_oa_config { 


struct drm_i915_query_item {

	__u64 query_id;

#define DRM_I915_QUERY_TOPOLOGY_INFO    1



	/*

	 * When set to zero by userspace, this is filled with the size of the
@@ -1655,6 +1656,67 @@ struct drm_i915_query { 
	__u64 items_ptr;

};



/*

 * Data written by the kernel with query DRM_I915_QUERY_TOPOLOGY_INFO :

 *

 * data: contains the 3 pieces of information :

 *

 * - the slice mask with one bit per slice telling whether a slice is

 *   available. The availability of slice X can be queried with the following

 *   formula :

 *

 *           (data[X / 8] >> (X % 8)) & 1

 *

 * - the subslice mask for each slice with one bit per subslice telling

 *   whether a subslice is available. The availability of subslice Y in slice

 *   X can be queried with the following formula :

 *

 *           (data[subslice_offset +

 *                 X * subslice_stride +

 *                 Y / 8] >> (Y % 8)) & 1

 *

 * - the EU mask for each subslice in each slice with one bit per EU telling

 *   whether an EU is available. The availability of EU Z in subslice Y in

 *   slice X can be queried with the following formula :

 *

 *           (data[eu_offset +

 *                 (X * max_subslices + Y) * eu_stride +

 *                 Z / 8] >> (Z % 8)) & 1

 */

struct drm_i915_query_topology_info {

	/*

	 * Unused for now. Must be cleared to zero.

	 */

	__u16 flags;



	__u16 max_slices;

	__u16 max_subslices;

	__u16 max_eus_per_subslice;



	/*

	 * Offset in data[] at which the subslice masks are stored.

	 */

	__u16 subslice_offset;



	/*

	 * Stride at which each of the subslice masks for each slice are

	 * stored.

	 */

	__u16 subslice_stride;



	/*

	 * Offset in data[] at which the EU masks are stored.

	 */

	__u16 eu_offset;



	/*

	 * Stride at which each of the EU masks for each subslice are stored.

	 */

	__u16 eu_stride;



	__u8 data[];

};



#if defined(__cplusplus)

}

#endif

CRA Git | Maintained and supported by SUSTech CRA and CCSE