Commit c8210a57 authored May 18, 2020 by Bart Van Assche Committed by Jens Axboe May 19, 2020

block: Fix type of first compat_put_{,u}long() argument



This patch fixes the following sparse warnings:

block/ioctl.c:209:16: warning: incorrect type in argument 1 (different address spaces)
block/ioctl.c:209:16:    expected void const volatile [noderef] <asn:1> *
block/ioctl.c:209:16:    got signed int [usertype] *argp
block/ioctl.c:214:16: warning: incorrect type in argument 1 (different address spaces)
block/ioctl.c:214:16:    expected void const volatile [noderef] <asn:1> *
block/ioctl.c:214:16:    got unsigned int [usertype] *argp
block/ioctl.c:666:40: warning: incorrect type in argument 1 (different address spaces)
block/ioctl.c:666:40:    expected signed int [usertype] *argp
block/ioctl.c:666:40:    got void [noderef] <asn:1> *argp
block/ioctl.c:672:41: warning: incorrect type in argument 1 (different address spaces)
block/ioctl.c:672:41:    expected unsigned int [usertype] *argp
block/ioctl.c:672:41:    got void [noderef] <asn:1> *argp

Fixes: 9b81648c ("compat_ioctl: simplify up block/ioctl.c")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 10ec5e86

block/ioctl.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -204,12 +204,12 @@ static int put_u64(u64 __user *argp, u64 val)
		}

		#ifdef CONFIG_COMPAT
		static int compat_put_long(compat_long_t *argp, long val)
		static int compat_put_long(compat_long_t __user *argp, long val)
		{
		return put_user(val, argp);
		}

		static int compat_put_ulong(compat_ulong_t *argp, compat_ulong_t val)
		static int compat_put_ulong(compat_ulong_t __user *argp, compat_ulong_t val)
		{
		return put_user(val, argp);
		}

Admin message