Commit c81ea720 authored Feb 03, 2020 by Andy Shevchenko Committed by Petr Mladek Feb 11, 2020

console: Don't perform test for CON_BRL flag

We don't call braille_register_console() without CON_BRL flag set.
And the _braille_unregister_console() already tests for console to have
CON_BRL flag. No need to repeat this in braille_unregister_console().

Drop the repetitive checks from Braille console driver.

Link: http://lkml.kernel.org/r/20200203133130.11591-1-andriy.shevchenko@linux.intel.com


To: linux-kernel@vger.kernel.org
To: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>

parent a4fe2b4d

drivers/accessibility/braille/braille_console.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -347,8 +347,6 @@ int braille_register_console(struct console *console, int index,
		{
		int ret;

		if (!(console->flags & CON_BRL))
		return 0;
		if (!console_options)
		/* Only support VisioBraille for now */
		console_options = "57600o8";
		@@ -371,8 +369,6 @@ int braille_unregister_console(struct console *console)
		{
		if (braille_co != console)
		return -EINVAL;
		if (!(console->flags & CON_BRL))
		return 0;
		unregister_keyboard_notifier(&keyboard_notifier_block);
		unregister_vt_notifier(&vt_notifier_block);
		braille_co = NULL;

Admin message