Commit c81d0b6c authored Aug 10, 2020 by Marc Kleine-Budde

can: tcan4x5x: tcan4x5x_can_remove(): fix order of deregistration

Change the order in tcan4x5x_can_remove() to be the exact inverse of
tcan4x5x_can_probe(). First m_can_class_unregister(), then power down the
device.

Fixes: 5443c226 ("can: tcan4x5x: Add tcan4x5x driver to the kernel")
Cc: Dan Murphy <dmurphy@ti.com>
Link: http://lore.kernel.org/r/20201019154233.1262589-10-mkl@pengutronix.de


Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent 1ff203ba

drivers/net/can/m_can/tcan4x5x.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -527,10 +527,10 @@ static int tcan4x5x_can_remove(struct spi_device *spi)
		{
		struct tcan4x5x_priv *priv = spi_get_drvdata(spi);

		tcan4x5x_power_enable(priv->power, 0);

		m_can_class_unregister(priv->mcan_dev);

		tcan4x5x_power_enable(priv->power, 0);

		return 0;
		}

Admin message